search

marcolago / flowtime.js

Flowtime.js HTML5/CSS3/JS Websites and Presentation Framework
https://marcolago.github.io/flowtime.js/
MIT License
1.34k stars 236 forks source link

Progress Indicator not working in examples #64

Closed tfer closed 8 years ago

tfer commented 8 years ago

Of all the index.html files in the repo, the Progress Indicator only works in three of them: the demo at the top level, the example in the 'auto-id' folder, and the example in the 'native-zoom' folder.

For all the others, the Progress Indicator highlites the first rectangle and never moves no matter what section/page you are on.

Diff'd a working and non-working index.html, I don't see what could be causing this.

Tom

marcolago commented 8 years ago

Hi @tfer. Thanks for pointing out. It’s just a javascript error because I’ve broke some examples with a missing callback. I’ll fix this issue just tonight, just after my wife’s birthday party :P

I’ll comment here when done.

marcolago commented 8 years ago

Ok, fixed and pushed to master. @simobasso was too much zealous in linting the code ;)

Let me know if you experience some other problems.

simobasso commented 8 years ago

Sorry 😳

marcolago commented 8 years ago

It was my fault, @simobasso. I had to initialize the var to null and not to undefined to prevent this kind of confusion.

Now everything is ok ;)

tfer commented 8 years ago

Yes, the progress indicator is working in all the examples.

However, I think the "Grid Navigation False Demo" is not doing what it claims to do, ..., I'll open another issue.