search

marcolertora / bareos-tasks-plugins

Specific application's backup for Bareos: XenServer, PostgreSQL, MySQL, Oracle
GNU Affero General Public License v3.0
8 stars 1 forks source link

Integration into the Bareos core repository? #1

Open joergsteffens opened 2 years ago

joergsteffens commented 2 years ago

An older version of this Bareos plugin has been integrated into the Bareos core repository and adapted for Bareos >= 20, see https://github.com/bareos/bareos/tree/master/contrib/fd-plugins/bareos_tasks

bareos_tasks now works with current versions of Bareos, is structured in directories, is integrated in automatic testing (only bareos_tasks.mysql), packaged as bareos-contrib-filedaemon-python-plugins (currently only in https://download.bareos.org/bareos/experimental/nightly).

However, this is all based on old commits contributed to Bareos. Are there plans to update/sync the current code into the Bareos main repository?

HOSTED-POWER commented 9 months ago

Hello @joergsteffens , unfortunately during that integration some mistakes were made, which leads to a completely non functioning pgsql plugin.

I also saw there was a switch made to BytesIO instead of StringIO , which I find rather strange? Wouldn't the StringIO be the logical replacement for Python3 looking at the original code here?

So I would have expected:

from io import StringIO , Instead this was used: from io import BytesIO

Why was this done? Certain functions now need encode() function to convert from byte to string. I suppose it was done on purpose, but some explanation could come in handy :D

Are there any new/interesting features in this repo which are not integrated? We started with porting this repo to Python3 already, but then stopped when we found the one in Bareos github repo... (We thought all fixes were there already)

Here is also a pull request making the pgsql working again: https://github.com/bareos/bareos/pull/1641/commits

joergsteffens commented 6 months ago

Hello @joergsteffens , unfortunately during that integration some mistakes were made, which leads to a completely non functioning pgsql plugin.

I also saw there was a switch made to BytesIO instead of StringIO , which I find rather strange? Wouldn't the StringIO be the logical replacement for Python3 looking at the original code here?

So I would have expected:

from io import StringIO , Instead this was used: from io import BytesIO

Why was this done? Certain functions now need encode() function to convert from byte to string. I suppose it was done on purpose, but some explanation could come in handy :D

Are there any new/interesting features in this repo which are not integrated? We started with porting this repo to Python3 already, but then stopped when we found the one in Bareos github repo... (We thought all fixes were there already)

Here is also a pull request making the pgsql working again: https://github.com/bareos/bareos/pull/1641/commits

Fixed with https://github.com/bareos/bareos/pull/1659