search

marcomusy / pianoplayer

Automatic fingering generator for piano scores
MIT License
721 stars 81 forks source link

Odd results for some accidentals #3

Closed jncarey closed 6 years ago

jncarey commented 6 years ago

This is a neat piece of software -- thanks for writing it!

I've been playing with it a bit and noticed that for some "weird" accidentals like Cb the program outputs bizarre fingering choices. If I rewrite the note as B the fingering makes much more sense. I haven't tried the other comparable accidentals (B#, E#, Fb) to know if this is a general or specific problem (nor have I looked at double sharps or double flats). You may not even be actively working on this software anymore, but in case you are this is a minor issue that could use correcting. Thanks!

Best, Jeffrey

mhoangvslev commented 6 years ago

I think that fingering is completely per person basis. It is interesting to see a methodical approach to unify fingering techniques, but I think ultimately, you should always bring a pencil with you :)

jncarey commented 6 years ago

Apologies if my post was unclear: the important point was not that the program sometimes outputs fingering choices that I personally consider odd. The point was that the program outputs entirely different fingering choices for two passages that are completely identical except for one version containing a Cb and the other version containing a B in its place.

marcomusy commented 6 years ago

Dear Jeffrey, thanks for your comment which for some reason I didn't notice. I'm currently revising this package so I will try to reproduce and fix the bug you mentioned!