search

marcopeg-dev / m07-cv-frontend

Frontend for M07 class project
4 stars 3 forks source link

Default image to show if element is empty #48

Open VernitaJ opened 4 years ago

VernitaJ commented 4 years ago

When profile_pic is empty on backend, default image should be shown.

What is looks like now: image

NicolaWinterson commented 4 years ago

Hi, the PR above seems to fix this issue. If you agree you can close this issue.

AHMADanis commented 4 years ago

@VernitaJ, I don't think this is a good idea to have a transparent placeholder in absence of user's image. If the user don't have an image then there should be something to represent the user.

VernitaJ commented 4 years ago

@AHMADanis

  1. It's not working correctly after merge.
  2. The image thumbnail is still there, which is why we should apply a default image. Default image can be something like image