search

marcopeg-dev / m07-cv-frontend

Frontend for M07 class project
4 stars 3 forks source link

Add user form Which allowed to create a new user. #60

Open Deve1980 opened 4 years ago

Deve1980 commented 4 years ago

We can create a new user. Popup msg will alert when we have two cases 1.Success msg 2.Error msg I still work on this popup msg box. There is a need to add loading indicator while it's sending post request

paulatorre commented 4 years ago

Hi Noor, I've tested it and there's a couple of things to fix. a link in home view to add the new user and a way to generate a unique id

VernitaJ commented 4 years ago

The Link to the add-user view should be shown in the home-view layout. It throws out an error when I try to add a user with all input fields filled - I am not sure why. Perhaps connected to the backend?

Deve1980 commented 4 years ago

@VernitaJ There is already a button but I missed add it when I make PR. For the error, I removed the user id from post request just to have an error msg. I re added user id to the request.

Deve1980 commented 4 years ago

@paulatorre for now we are using the user name as an user id, may be we can generate user id by using his email.

NicolaWinterson commented 4 years ago

I was able to submit a user (the success graphic was really great), but then I couldn't exit from the page (via the go home button) without refreshing. There was form validation still being applied under the button and on the form