search

marcopeocchi / yt-dlp-web-ui

A terrible web ui for yt-dlp. Designed to be self-hosted.
Mozilla Public License 2.0
657 stars 67 forks source link

unix socket support (useful behind nginx proxy) #143

Closed cyberb closed 3 months ago

cyberb commented 3 months ago

I am maintainer of https://github.com/syncloud/platform where I help non tech people with self-hosting popular apps.

I would like to add your app as it is easy to use, but I would like to add unix socket support as I am not using ports (tcp) for running multiple apps on a single PC for maintenance simplicity purposes.

cyberb commented 3 months ago

I see you are using logger.Error to log errors but you are not returning and I do not think that library panics either. That makes app to continue the execution which makes it fail later with potentially another error, I think it is practical to fail fast usually by returning the err.

marcopeocchi commented 3 months ago

Hi @cyberb,

You're right, my bad slog.Error does not end the current goroutine execution. I will take it in consideration, anyway points where the app needs to immediate stop are few.

Regarding your PR: thank for you wanting to feature my project into syncloud, supporting UNIX sockets it's a nice addition.

cyberb commented 3 months ago

Thanks, do you plan a release at some point?

marcopeocchi commented 3 months ago

I will issue a new release Once I will test the "file base logging feature" I was working on (might be even today evening).