marcopeocchi / yt-dlp-web-ui

A terrible web ui for yt-dlp. Designed to be self-hosted.
Mozilla Public License 2.0
660 stars 68 forks source link

APP TITLE AND LOGIN #89

Closed brixxnatt closed 8 months ago

brixxnatt commented 9 months ago

hello , 1-APP TITLE do not change inside the pages , only at the browser header 2-Login user name and password , should always be presented per session 3- when we download via your script , the files is always 644 permission , it needs to be always 755 permission

thanks

marcopeocchi commented 9 months ago

hi @brixxnatt,

1) ok, I'll provide a way to change that 2) being presented per session it implies that the session cookie should have a short expire time, which is non deterministic behaviour. By design the session cookie has a TTL of 30 days. One thing that's possible will be changing the TTL via the config file 3) 644 is correct, the file should not be executable and only readable from other users. Anyway, it's not my web-ui, those permission are set be yt-dlp itself IIRC

brixxnatt commented 9 months ago

yes ttl should be configued as this is a major secutiry issue since the script can upload and delete videos , so i guess is better is to have a login session once we logout , logout and login is needed to this type of scripts please

brixxnatt commented 9 months ago

or its okay we can do ngx_http_auth_basic_module in nginx

marcopeocchi commented 9 months ago

i wanted to reopen this issue to re-iterate to some points.

After enabling authentication, via config or cli params, you'll find this screen immagine After filling the login form immagine immagine

Once logged in the clicking the icon-button for the log-ing page logs you out. Once logged-off the session cookie will be invalidated and removed.

If you're logged out, instead, it provides you the ability to log-in again.

I hope it solves @brixxnatt questions on authentication side.

Regarding file permission i will mark this issue as "wontfix"

brixxnatt commented 8 months ago

i thank you the 755 files fixed , i have no idea where to put this or how to work it

Usage yt-dlp-webui: -auth Enable RPC authentication -conf string Config file path -driver string yt-dlp executable path (default "yt-dlp") -out string Where files will be saved (default ".") -port int Port where server will listen at (default 3033) -qs int Download queue size (default 8) -user string Username required for auth -pass string Password required for auth

marcopeocchi commented 8 months ago

@brixxnatt i'm glad that the "files permission" thing has found a fix. Can you please explain more the second part? :raised_eyebrow: