search

marcopixel / monstercat-visualizer

A real time audio visualizer for Rainmeter similar to the ones used in the Monstercat videos.
MIT License
917 stars 102 forks source link

No dynamic genre color with CAD/MusicBee with 1.7.0+ #57

Closed defvs closed 7 years ago

defvs commented 7 years ago

Hey ! Found this when updating. All my genres are well tagged. Was working fine also before the update. I have not tested with another player, just with MusicBee with CAD plugin enabled.

tjhrulz commented 7 years ago

I'm away from a computer for the rest of the day but I must have broken this somehow with my color changes. I'll try to get on to check it out tonight when I get to relatives house.

My bet is that the set option command to refresh the colors is not running on genre change.

tjhrulz commented 7 years ago

Well I am a giddy goat. I forgot to turn on dynamic variables in the measure that handles the switching between genre and cover colors. Since genre used a variable and not a measure it would not update correctly. Once I get my dev machine online I'll push a commit.

defvs commented 7 years ago

Can you link the specified commit to quick-fix on my local files, or at least to push a pr ?

marcopixel commented 7 years ago

He linked with the closing commit. check d98b987697ce75a31080d0178e43836d8a032a5f.

tjhrulz commented 7 years ago

The commit gets linked automatically when I closed the issue in the commit but if you need a link because your GitHub app doesn't support/show it it's https://github.com/MarcoPixel/Monstercat-Visualizer/commit/d98b987697ce75a31080d0178e43836d8a032a5f

Also for future reference you can merge changes from here to your repo without any action on our end.

defvs commented 7 years ago

Will clone that. Thanks for the quick fix

tjhrulz commented 7 years ago

Well given it existed for a month without anyone knowing I wouldn't call it quick 🤣 thanks for reporting it