marcopixel / r6operators

r6operators is a collection of high-quality vectorized Rainbow Six: Siege Operator icons & metadata for Node.js

https://r6operators.marcopixel.eu

MIT License

100 stars 10 forks source link

Add operator cost (unlock prices) #28

Closed derkrasseleo closed 2 years ago

derkrasseleo commented 2 years ago

I would like to use the operator cost for a project, but this isn't a property yet, would it be possible to integrate this? I would help with this of course..

derkrasseleo commented 2 years ago

Hope this is useful

29

marcopixel commented 2 years ago

Hi @leochras, thanks for your interest in my project 👋

I think it's a good idea to have the unlock prices in the metadata of the operators and it seems to be quite easy to fetch all that data - only thing i'm missing from your pull request is the individual operators prices assigned as it seems it's only declared in the interface for now.

If you add those prices to each corresponding operator in your pull request, i will take a look at it 👍

derkrasseleo commented 2 years ago

Hi, hope it's okay to have the price as fixed values instead of a number, or what do you think? I thought maybe they add 30000 renown operators at some point but on the other hand mistakes could be avoided. I will add 1000 as an option, though, as I forgot that. When I'm finished adding all prices, I am going to make one pr for the whole issue. Is that okay for you?

derkrasseleo commented 2 years ago

Another question is: Which value does a recruit get? 0? Nan?

edit: just noticed recruits don't have meta, so they also get no price I assume..

derkrasseleo commented 2 years ago

Hope I got everything right..

30

marcopixel commented 2 years ago

Added with https://github.com/marcopixel/r6operators/commit/f2f5b62a1c29b2b023126d1a9af8bca8dce1936f on Release 2.1.0.

Thanks again for your help 👍