marcopixel / r6operators

r6operators is a collection of high-quality vectorized Rainbow Six: Siege Operator icons & metadata for Node.js
https://r6operators.marcopixel.eu
MIT License
102 stars 10 forks source link

Icon colour consistency #3

Closed joeyfoo closed 2 years ago

joeyfoo commented 4 years ago

I noticed that some of the icons colours are not particularly consistent. For example, the lighter black fill colour for Alibi, Blackbeard, and Finka, compared to the deep/pure blacks used for the other icons.

Ideally, I'd like to also do a pass to make sure that colours are consistent within each CTUs when viewed side-by-side. The colours could also be adjusted with reference to official assets (but the priority would be to make sure it's internally consistent).

I'd love to take this on, just popping an issue here to make sure there are no issues* before I start.

(P.S. I was going to discuss this on the R6DB Discord, but I see it's gone now?)

* Pun not intended

marcopixel commented 4 years ago

I've also wanted to do this a while ago, but never got the time to do it properly. If you want, you could join the r6stats discord where we can move the conversation into #development or just keep the conversation here in the issue.

joeyfoo commented 4 years ago

I'm already in the R6Stats Discord: I'll drop a message there and here once I start!

Bl0n commented 3 years ago

Subscribing to this! Especially the much lighter blacks in Maestro and Maverick are quite noticeable even if the icon is scaled down to like 35px x 35px as it is in my app.

joeyfoo commented 3 years ago

Oh god I haven't done any work on this since May 2020. If this is something we want to fix I can re-add this to my to-do list

Bl0n commented 3 years ago

My bad, I was just looking at the Flores addition, and didn't notice how old this issue was. It's super low prio, but was definitely something I noticed as well. Sorry for resurrecting this. 😬

marcopixel commented 3 years ago

Sorry for having no progress on this issue, had a few busy months and couldnt bring up the motiviation to start on this problem.

So the current list of high-priority icons are:

alibi
blackbeard
finka
lion
maestro
maverick
valkyrie

Those icons have either the most glaring issues regarding color/contrast and need to be fixed first, but eventually we need to update all icons before May 2020 to adhere to the new template file which uses a slightly adjusted size (not by much, many icons are just 1-3pt off).

If anyone wants to start with the icons, i'll recommend you to start with the ones above. I'm also trying to fix at least one icon per week as long as i find enough time/motivation to do it 😅

joeyfoo commented 3 years ago

I'll also suggest assembling some form of colour palette so the updated colours are internally consistent. We should only need each CTU/season's accent colour, as well as deciding if we're using #000000 as black or if we're using a dark grey.

Bl0n commented 3 years ago

Here are the following Operator icons SVG with the inconsistent light-grey changed to the black that all the other operator icons have:

alibi
blackbeard
finka
lion
maestro
maverick
valkyrie

inconsistent_to_black_colour.zip

marcopixel commented 3 years ago

Well, since it seems that Ubisoft changed the style of the icons, i'm probably waiting for the test server or the official website to update if they do it across all their channels or if it's just for the icons ingame.

If they do indeed change all icons, this will take quite a while to update all the icons but it might be useful to properly set color rules as we've discussed before.

marcopixel commented 2 years ago

Can be closed because of the rework of the operator icons (see #22).