search

marcoraddatz / homebridge-docker

Dockerized Homebridge. No plugins pre-defined, hassle-free setup. Read instructions!
Apache License 2.0
127 stars 47 forks source link

Add homebridge -P option to allow for local plugin development #1

Closed tfohlmeister closed 7 years ago

tfohlmeister commented 7 years ago

Hi! Thanks for the great container! I created a tiny addition to allow for local plugins and local plugin development. HomeBridge takes the parameter P to look for plugins in the specified folder (see https://github.com/nfarina/homebridge#plugin-development).

I think it's a great addition to enable everyone to write their own plugins without the need to push them to NPM.

As far as I can tell from the HomeBridge source code there are no negative side effects, even if the folder provided to -P does not exist. It should be safe to hard code it like this.

Would be glad if you could add this so I don't have to run my own fork of this. Thanks!

marcoraddatz commented 7 years ago

Cool, sounds great!

Will push it to Docker hub soon.

tfohlmeister commented 7 years ago

Thanks! Oh yeah I didn't realize the source repo for your docker build was on Bitbucket not on Github.

marcoraddatz commented 7 years ago

Yes, it started out as private repo and when I decided to make it public, I didn't find a way to change the repo url within Docker Hub. That's why I have to mirror it until I find a solution... :/

marcoraddatz commented 7 years ago

Alright, I just released a new version. Your changes are included. Many thanks!

marcoraddatz commented 7 years ago

The next version requires an explicit environment setting to start Homebridge with plugin support. I just wanted to warn you about that. Have a look at https://github.com/marcoraddatz/homebridge-docker/tree/develop#plugin-development for the options.