search

marcorinck / jsf-updates-angular

Update angularJS after JSF Ajax requests are complete
5 stars 2 forks source link

String#contains() is not defined #2

Closed stephanrauh closed 9 years ago

stephanrauh commented 9 years ago

For some reason, JUA complains about the missing contains() function. Maybe it's better to replace the two occurences with indexOf()>=0.

As far as I can see, jQuery is initialized before JUA:

image

marcorinck commented 9 years ago

indeed, String.contains is not javascript standard (its coming from our internal library), sorry about that. This should be fixed, yes.

However, I prefer to seperate pull requests of issues, as the other issue your PR is trying to fix, needs to be discussed.

Can you split the PR https://github.com/marcorinck/jsf-updates-angular/pull/4 please?