Open KaisHaddadin opened 1 year ago
Hey @KaisHaddadin, thanks for the detailed report!
I think we removed the bundler_version
argument in favor of speed. The issue with specifying the bundler version was that it ran and built the docker image on every action run, which wasn't super efficient.
What we are doing now is pre-building the image once so the action run just needs to download it and run it, instead of building it first and then run it.
I'm wondering if you can use marcoroth/dependabot-bump-together-action@v0.2.0
in the meantime to make sure it runs again.
good idea, we will try this for now and see whether this solves the problem.
Thanks Marco for the quick feedback!
Unfortunately, this will not work:
ERROR: Error installing dependabot-omnibus: The last version of nokogiri (~> 1.8) to support your Ruby & RubyGems was 1.13.10. Try installing it with
gem install nokogiri -v 1.13.10and then running the current command again nokogiri requires Ruby version >= 2.7, < 3.3.dev. The current ruby version is 2.6.5.114.
I am not sure also whether the problem will be solved when the correct bundler is used, it is maybe also related to used dependentbot version, we will try to further investigate to localize the problem better.
Hi Marco, hope you are doing well, I need to jump into the discussion.
A long the way to fix our problem with the PR Bump automation I found a announcement about dependabot-script which you are using for this project.
What does it mean for this repo? As it depends on is it still usable?
Do you know if the Docker image dependabot/dependabot-core has been removed from docker hub? At least it is not publicly visible.
Thank you very much!
Hey @mirsadmustedanagic, thanks for the heads-up!
This might actually be why it's not working as intended anymore. I didn't realize that they split up the Docker image.
And yes, you are right. They removed the dependabot/dependabot-core
image from Docker Hub which might be the root cause.
I'm not sure if we can fix it as is. We probably need to rewrite it so that it now relies on the new images published here: https://github.com/orgs/dependabot/packages?repo_name=dependabot-core
I ran into the docker issue as well. I really hope they can fix the docker scripts soon: https://github.com/dependabot/dependabot-script/pull/906.
I guess they are not going to fix them, since they migrated and split up their docker images.
I currently don't have a good setup to test the new images, but based on from what I've seen it might be enough to change the Dockerfile base image here https://github.com/marcoroth/dependabot-bump-together-action/blob/cf82f1cac3e79bdaf8db482d0cdb293ea27f66cc/Dockerfile#L1 and see if it still builds.
You can technically even test against your own repo to see if it works when you use the forked action, like:
steps:
- uses: [YOUR_FORK]/dependabot-bump-together-action@main
with:
# ...
@KaisHaddadin @mirsadmustedanagic @domoritz check this out: https://github.blog/2023-08-24-a-faster-way-to-manage-version-updates-with-dependabot/
Looks like I can deprecate this GitHub Action!
Hi Marco :)
we are getting some problems when running the action for a while now, the log is:
is there a reason why the bundle version parameter is removed? the error that we saw now is maybe related to the fact that the bundler that we use in our code base is not the same as the one used by default in the library.