search

marcos930807 / awesomeDialogs

A new Flutter package project for simple a awesome dialogs
Other
339 stars 110 forks source link

Covert to lint package for strict rules, fixed typos, followed dart n… #104

Open YDA93 opened 2 years ago

YDA93 commented 2 years ago

…ame conventions.

marcos930807 commented 2 years ago

Hi @YDA93 I follow the lint rule in other projects and I like it, the problem with your Pr is that although it is true that by conversion the enum must be named in CamelCase this would be breaking Change for existing users and that is the main reason why I have not fixed some typos. A good example is the typo in "onDismissCallback". In the near future Maybe a release a mayor version with this Breaking changes and others ideas that involve better support for animations, styling etc. At that point make sense fixing typo, and effective dart lint rules.