Add more configuration options

[GoogleCodeExporter]

The attached patch adds the following configuration options:

- skin
- toolbarStartupExpanded
- templates_files
- filebrowserFlashBrowseLinkUrl
- filebrowserImageBrowseLinkUrl

André

Original issue reported on code.google.com by zorknika@gmail.com on 10 Jun 2011 at 1:24

Attachments:

• CKEditorConfig.patch

[GoogleCodeExporter]

Updated patch with a two error corrections

Original comment by zorknika@gmail.com on 10 Jun 2011 at 2:17

Attachments:

• CKEditorConfig.patch

[GoogleCodeExporter]

Thanks zorknika. I confess I've not done patches in Eclipse before, but I noted 
the patch shows: CKEditorConfig.java (revision 88)

Yet my copy seems to be version 85.

Do you really need the "get" methods? I know that's javabeans and all, but this 
config object doesn't include such getters except for those few elements that 
are not set via the inPageConfig JS (they are used to query the object to set 
other objects during editor setup).  

I'm happy to add it all, but checking to determine if you really need the 
getSkin(), getToolbarStartupExpanded(), getFilebrowserFlashBrowseLinkUrl(), 
getFilebrowserImageBrowseLinkUrl(). We normally pass in the config object and 
then never query it again, but if there's a need to query, I may bite the 
bullet and make all of the others have getters too.

Original comment by yoz...@gmail.com on 10 Jun 2011 at 6:45

[GoogleCodeExporter]

Original comment by yoz...@gmail.com on 10 Jun 2011 at 6:45

• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Also, can I confirm that filebrowserFlashBrowseLinkUrl and 
filebrowserLinkBrowseUrl are valid, working ckeditor config options?

I know the documentation is not always up to date, but I don't see those listed 
http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.config.html

It looks like I'll also change stylesCombo_stylesSet to stylesSet as I hadn't 
noticed this changed back in 3.3.

Original comment by yoz...@gmail.com on 10 Jun 2011 at 7:04

[GoogleCodeExporter]

The two option actually work and are not documented.

http://cksource.com/forums/viewtopic.php?f=11&t=22386

André

Original comment by zorknika@gmail.com on 14 Jun 2011 at 8:57

[GoogleCodeExporter]

Okay, we'll add them in, and we'll remove the get methods from the config class 
since it's not really a bean -- that is, once you pass it to the editor field 
constructor, it's never used again. You just set the values then pass it in and 
forget about it -- if you change the values it'll have no effect on the editor 
already created, though you could probably pass it in to another editor -- but 
why?

Thanks for the addition. It'll be in the 1.4 release once we test our side.

Original comment by yoz...@gmail.com on 14 Jun 2011 at 5:20

• Changed state: Fixed

[GoogleCodeExporter]

Thanks (And of course you are right about the getXY methods ;)

Original comment by zorknika@gmail.com on 15 Jun 2011 at 2:26