search

marcosgriselli / EasyTransitions

A simple way to create custom interactive UIViewController transitions
MIT License
1.68k stars 92 forks source link

Use UIScrollView's gesture instead of adding a new UIPanGestureRecognizer #23

Open bryan1anderson opened 5 years ago

bryan1anderson commented 5 years ago

I am using this library to present several UIViewControllers. Many of them have UIScrollView subviews.

ModalTransitionDelegate.interactiveController.gestureRecognizer is private and this makes it impossible for me to tell my views to prefer their gesture recognizers over the interactive controllers gesture recognizer.

What is your recommended way around this?

marcosgriselli commented 5 years ago

Hi Bryan, good point. I never had the time to actually implement transitions with UIScrollView easily. Let me take a short look at it in the upcoming days and I'll try to come up with a solution. I wish I had a temporal solution you could implement to work around it but it will require editing the Pan enum and all of the related code. I'll keep you updated on this.

sevgjan commented 5 years ago

@bryan1anderson were you able to implement the library with UIScrollView because I have a very strange top inset which I fix it on opening, but dismissal is somehow jumping and not good when returning on UICollectionViewCell when dismissing DetailViewController with button.

@marcosgriselli first, thanks for your great work. Do you have any example on how can this transition be used with UIScrollView inside of CardDetail? Something similar to AppStore?

marcosgriselli commented 5 years ago

@sevgjan I'll be working on this shortly. I'll keep you guys posted.

sevgjan commented 5 years ago

@marcosgriselli hey man, sorry to bother, any news on this issue? did we miss something?

marcosgriselli commented 5 years ago

Hey @sevgjan no worries. I'm gonna be totally honest I haven't had the time to work on this. I took a look at it when the issue was created and realized it wasn't as easy as applying a hack so I can't give an estimate of when this will be fixed/supported. Sorry for the inconvenience.

sevgjan commented 5 years ago

No problem @marcosgriselli , just wanted to check if there's any news on this issue.