search

marcosgriselli / SwipeableTabBarController

UITabBarController with swipe interaction between its tabs.
MIT License
1.54k stars 107 forks source link

Is disabling tap animation not supported anymore? #90

Closed wasp898 closed 4 years ago

wasp898 commented 4 years ago

I haven't found a way to disable the animation when tapping on a tab. But several issues and commits indicate that this was possible before. Even the example app features this code (which is now commented) out:

//tapAnimatedTransitioning = nil

But tapAnimatedTransitioning is a get-only property.

Is there another way to achieve this now?

wasp898 commented 4 years ago

I guess setting animationDuration to 0.0 does the job. The example should be updated. I could do that myself I guess. I'm closing this issue for now. Anyway, I did find a bug though. In my app I have other gestures which somehow cause the currentAnimatedTransitioningType to be of type Swipe instead of Tap type. After that, when I tap I still see the animation of default duration. Will try to propose a solution.

JMCPH commented 4 years ago

Did you find to manage a clean fix for this?

wasp898 commented 4 years ago

Did you find to manage a clean fix for this?

I did actually. I’ll push a PR asap.