search

marcosgriselli / ViewAnimator

ViewAnimator brings your UI to life with just one line
MIT License
7.3k stars 488 forks source link

Update to Swift 5 #56

Closed ApolloZhu closed 5 years ago

ApolloZhu commented 5 years ago

Fixed warnings in Swift 5 and updated project settings.

But should utility methods for generating random numbers really be part of the public API (given that SE-0202 introduced unified RNG with Swift 4.2)?

ApolloZhu commented 5 years ago

I don't have access to the build log, but I assume it failed because bitrise is not using Xcode 10.2? Should it be any other reason, please let me know.

marcosgriselli commented 5 years ago

I don't have access to the build log, but I assume it failed because bitrise is not using Xcode 10.2? Should it be any other reason, please let me know.

Right, I just re-launched the build with an updated stack.

marcosgriselli commented 5 years ago 
But should utility methods for generating random numbers really be part 
of the public API (given that SE-0202 introduced unified RNG with Swift 4.2)?

We can remove those. I'll add a patch for it after.

marcosgriselli commented 5 years ago

Thanks for the PR @ApolloZhu! I'll make a release now