search

marcosgriselli / ViewAnimator

ViewAnimator brings your UI to life with just one line
MIT License
7.28k stars 485 forks source link

added back support for "from" animationType #76

Closed CharlieOxendine closed 3 years ago

marcosgriselli commented 3 years ago

Thanks @CharlieOxendine. Was planning to add this property back. Will merge it later today/tomorrow.

marcosgriselli commented 3 years ago

@CharlieOxendine there's an unexpected file name change included in the PR that causes problems:

Screen Shot 2021-02-20 at 09 56 58 If you try compiling your fork you'll run into this error message: 

 error: Build input file cannot be found: '/Users/user/path/ViewAnimator-master/Sources/Models/AnimationType.swift' (in target 'ViewAnimator' from project 'ViewAnimator')
CharlieOxendine commented 3 years ago

Just changed the file name back. Let me know if that works! Thanks! @marcosgriselli

marcosgriselli commented 3 years ago

@CharlieOxendine the Directions.swift file is missing from the Xcode project so the library is failing to compile. This is a screenshot from your fork:

Screen Shot 2021-02-22 at 12 47 44

CharlieOxendine commented 3 years ago

Sorry for the late reply, but the file name is Direction.swift, but it does exist and runs fine for me. Would the file name "Directions" missing be what's causing the issue? I can push a version with the file name changed to my fork if that is what's causing the issues

CharlieOxendine commented 3 years ago
Screen Shot 2021-06-12 at 1 08 58 PM
marcosgriselli commented 3 years ago

@CharlieOxendine I just pulled your fork. The file is not added to Xcode even though it exists in the system folder:

image

You should be able to replicate this by cloning your fork again. Xcode can get files to a weird state when renaming + adding/removing them so it might be using some cache version on your local machine but it does not work for others or for CI.

Dragging and dropping Directions.swift to the Models folder in the Xcode navigator should fix the issue. If you are currently seeing Directions.swift in the Models folder on Xcode simply delete it (Remove References) and drag-drop it again.

CharlieOxendine commented 3 years ago

I just cloned my project again but I don't see this error. I tried deleting the Directions.swift file and dragging it back in. Should I try and push with that? Sorry for the trouble

marcosgriselli commented 3 years ago

I just cloned my project again but I don't see this error. I tried deleting the Directions.swift file and dragging it back in. Should I try and push with that? Sorry for the trouble

Yeah, there should be a change in the Xcode project file to commit.

No worries! I'm always down to work out issues with anyone that wants to contribute :)

CharlieOxendine commented 3 years ago

The only change to commit is with ".swiftpm"

marcosgriselli commented 3 years ago

@CharlieOxendine can you give me push permissions to your fork? I'm not 100% sure what's going on on your side (maybe using the Swift Package project instead of the Xcode one) but I have the line to fix it so we can merge it.

CharlieOxendine commented 3 years ago

Yeah, will do👍🏻