Added route dependency injection for anonymous controllers

marcoslin / angularAMD

Facilitate use of RequireJS in AngularJS

http://marcoslin.github.io/angularAMD

MIT License

734 stars 171 forks source link

Added route dependency injection for anonymous controllers #132

Open stargazer-2697 opened 9 years ago

stargazer-2697 commented 9 years ago

Fixes lost dependencies when routing with an anonymous controller. See discussion.

marcoslin commented 9 years ago

Hi,

Thanks for the pull request. Any reason to change the order of param in the test instead of changing the order of param in the angularAMD?

Sorry if I missed something obvious but day job is sucking every second of my life away at the moment.

stargazer-2697 commented 9 years ago

It's for simplicity really. The PR appends any local dependencies from config.resolve to the $inject property of the proxy controller. Since $scope is also a local dependency, I reordered the params so all the local dependencies will be adjacent. This way, I can simply iterate over arguments[2..n] instead of arguments[0] and then arguments[3..n].