marcoslin / angularAMD

Facilitate use of RequireJS in AngularJS
http://marcoslin.github.io/angularAMD
MIT License
734 stars 171 forks source link

Add support for Angular 1.5 components #163

Open benelliott opened 8 years ago

benelliott commented 8 years ago

Adds support for the new "component" syntactic sugar introduced in Angular 1.5.

marcoslin commented 8 years ago

@benelliott thanks for the pull request. Did you happen to had a chance to look at Travis errors?

andidev commented 8 years ago

So components does not work with latest version 0.2.1 of angularAMD?

benelliott commented 8 years ago

Hi @marcoslin @andidev , sorry for not looking into this further - I was having trouble getting angularAMD off the ground with a 1.5-component-heavy app and assumed that it was simply missing an alias for "component" but never got round to checking out the Travis errors.

benelliott commented 8 years ago

Just looking at the trace now - strangely, Travis seems to be erroring on the minified version of the lib even though I actually forgot to rebuild it (so it should be the same as master!). Is there any way to check that the current master branch actually passes the tests?

pratikf commented 8 years ago

+1

mrwogu commented 8 years ago

+1