search

marcoslin / angularAMD

Facilitate use of RequireJS in AngularJS
http://marcoslin.github.io/angularAMD
MIT License
734 stars 171 forks source link

added support for angular 1.5 component #171

Open gillbatesiii opened 8 years ago

gillbatesiii commented 8 years ago

Hi, I'd like to add support for Angular 1.5 components.

I've tried creating a simple component with it (just passed an object in and display the value) and it worked. I used Dojo as my AMD loader, though I expect it should also work with Requirejs.

Angular 1.5 components pass a JS object (option) instead of a function (constructor) as the second parameter, but since everything is just being passed directly to Angular I don't see this being an issue.

BTW I would like to mention that the way angularAMD was written, it made it easy to add support for an additional Angular feature. Thanks for making the code easy to modify, and thank you for making angularAMD.

andidev commented 8 years ago

See also PR #163 I think the build seems to fail in the main branch as well so it's probably not your commit causing it to fail.

@marcoslin Any ideas on why build is failing? Is this repo no longer maintained?

gillbatesiii commented 8 years ago

Thanks @andidev. I did notice belatedly that someone else already made an identical pull request, but I didn't see the comments.

For some reason I can't get npm test to run successfully on my windows machine even with a bash shell, so I've been relying on travis-ci.

gillbatesiii commented 8 years ago

@andidev you're right, I undid my changes and pushed, the build is still breaking

ghost commented 7 years ago

Hi there,

does it function meanwhile? I mean the component support?