search

marcosnils / bin

Effortless binary manager
MIT License
648 stars 45 forks source link

add force flag for update #101

Closed sascha-andres closed 3 years ago

sascha-andres commented 3 years ago

This PR suppresses the prompt asking to proceed with update, instead it goes straight to the update process

sascha-andres commented 3 years ago

@marcosnils Any further comments?

sascha-andres commented 3 years ago

@sirlatrom Agreed, is a better wording

marcosnils commented 3 years ago

There still seem to be some formatting issues with the code. Did you run go fmt? image

sascha-andres commented 3 years ago

If I run go fmt nothing changes locally, so it seems the run was successful. My IDE is configured to run it on save.

marcosnils commented 3 years ago

If I run go fmt nothing changes locally, so it seems the run was successful. My IDE is configured to run it on save.

That's correct. Not sure why github diff is showing those green marks though :confused: . I thought it was because it's incorrectly indented but again, doesn't seem to be the case.

@sirlatrom WDYT?

sirlatrom commented 3 years ago

If I run go fmt nothing changes locally, so it seems the run was successful. My IDE is configured to run it on save.

That's correct. Not sure why github diff is showing those green marks though 😕 . I thought it was because it's incorrectly indented but again, doesn't seem to be the case.

@sirlatrom WDYT?

Sorry for not getting back to you earlier. LGTM!

cristiand391 commented 3 years ago

Thank you @sascha-andres for working on this!