search

marcosnils / bin

Effortless binary manager
MIT License
648 stars 45 forks source link

Refactor confirmation prompt to separate pkg #132

Closed Stavrospanakakis closed 2 years ago

Stavrospanakakis commented 2 years ago

This commit refactors the confirmation prompt to a separate pkg.

Signed-off-by: Stavros Panakakis stavrospanakakis@gmail.com

sirlatrom commented 2 years ago

How about providing the io.Reader as a parameter to Confirm instead?

marcosnils commented 2 years ago

How about providing the io.Reader as a parameter to Confirm instead?

Check https://github.com/marcosnils/bin/pull/132#discussion_r847492299. I though it was easier to handle it separately :pray:

Stavrospanakakis commented 2 years ago

The branch had conflicts so I rebased :)