search

marcosnils / bin

Effortless binary manager
MIT License
648 stars 45 forks source link

https://github.com/pkolaczk/fclones installs Windows exe on Linux #134

Open njhallett opened 2 years ago

njhallett commented 2 years ago 
(ins)└─$ bin install --debug https://github.com/pkolaczk/fclones
   • debug logs enabled       
   • Config directory is: /home/niall/.config/bin
   • Download path set to /home/niall/bin
   • Getting latest release for pkolaczk/fclones
   • Filename fclones_0.23.0_amd64.deb doesn't have a supported extension
   • Removing fclones-0.23.0.tgz (URL https://api.github.com/repos/pkolaczk/fclones/releases/assets/64329227) with score 1 lower than 11
   • Keeping fclones-0.23.0-win.x86_64.zip (URL https://api.github.com/repos/pkolaczk/fclones/releases/assets/64329220) with highest score 11
   • Checking binary from https://api.github.com/repos/pkolaczk/fclones/releases/assets/64329220
   • Starting download of https://api.github.com/repos/pkolaczk/fclones/releases/assets/64329220
3.98 MiB / 3.98 MiB [----------------------------------------------------------------------------------------------------------------------------------------] 100.00% 8.57 MiB p/s 1s
   • Copying for fclones.exe@v0.23.0 into /home/niall/bin/fclones.exe
   • Done installing fclones.exe v0.23.0
(ins)└─$ tar tvfz fclones-0.23.0.tgz                                                                                                                                                  
drwxr-xr-x root/root         0 2022-05-03 09:08 ./                                         
drwxr-xr-x root/root         0 2022-05-03 09:08 ./usr/                                                                                                                                
drwxr-xr-x root/root         0 2022-05-03 09:08 ./usr/share/                               
drwxr-xr-x root/root         0 2022-05-03 09:08 ./usr/share/doc/ 
drwxr-xr-x root/root         0 2022-05-03 09:08 ./usr/share/doc/fclones/
-rw-r--r-- root/root      1236 2022-05-03 09:08 ./usr/share/doc/fclones/copyright
-rw-r--r-- root/root     25270 2022-05-03 09:08 ./usr/share/doc/fclones/README
drwxr-xr-x root/root         0 2022-05-03 09:08 ./usr/bin/       
-rwxr-xr-x root/root   4328480 2022-05-03 09:08 ./usr/bin/fclones
marcosnils commented 2 years ago

:wave:. bin it's trying to be smart by automatically picking the zip bundle since it's the one that matches the platform and architecture. You can see that the .tgz doesn't have the platform or the architecture on it's name. You can manually picky bundles by using the --all flag when installing. bin install --all https://github.com/pkolaczk/fclones should allow you to select the correct bundle.

njhallett commented 2 years ago

Hi, thanks for the reply. I'm so used to bin just working, that I didn't look to see if I could override anything. So, why doesn't it reject the contents of the .zip file rather than use an incompatible binary for the platform?

marcosnils commented 2 years ago

So, why doesn't it reject the contents of the .zip file rather than use an incompatible binary for the platform?

Because it's not smart enough (yet) :smile: . Yeah.. it'd be nice if on this case bin printed something like: "No matching binary could be found, use the --all flag to manually select a resut".. or something along those lines.

I'll leave this issue open to track it here. Contributions are welcome if you'd like to help out :sweat_smile: