marcosnils / bin

Effortless binary manager
MIT License
712 stars 47 forks source link

shorter bin install commands #170

Closed dfang closed 3 months ago

dfang commented 1 year ago

close #171

marcosnils commented 1 year ago

hey! thx for the contribution! Your PR gave me an idea. How about if we add a new command like bin alias to add or remove those aliases that can be stored in bin's config?

We could include the shorthands that you're proposing here as a default during config init or maybe through bin alias add --default to populate them.

Thoughts?

dfang commented 1 year ago

bin alias is good, but it should not be the top priority thing. as people can contribute to this file.

I think for the moment smart choose is more important. I mean for this case, 3 should be chosen. I noticed there are issues out on the list.

λ bin i dandavison/delta
   • Getting latest release for dandavison/delta
   • Starting download of https://api.github.com/repos/dandavison/delta/releases/assets/111116981
2.53 MiB / 2.53 MiB [---------------------------------------------------------------------------------] 100.00% 122.77 KiB p/s 22s

Multiple matches found, please select one:

 [1] delta-0.16.5-x86_64-apple-darwin/LICENSE
 [2] delta-0.16.5-x86_64-apple-darwin/README.md
 [3] delta-0.16.5-x86_64-apple-darwin/delta
 Select an option:
marcosnils commented 1 year ago

bin alias is good, but it should not be the top priority thing. as people can contribute to this file.

I agree... but I think moving that file shorthands to the bin config even without the bin alias command would be something very useful as users will be able to add / remove shorthands by manually editing the config file. WDYT?

I think for the moment smart choose is more important. I mean for this case, 3 should be chosen. I noticed there are issues out on the list.

yes, agree. I have some ideas on how to improve this, just need to find the time to try them out.

dfang commented 1 year ago

bin alias is good, but it should not be the top priority thing. as people can contribute to this file.

I agree... but I think moving that file shorthands to the bin config even without the bin alias command would be something very useful as users will be able to add / remove shorthands by manually editing the config file. WDYT?

it helps ...

marcosnils commented 1 year ago

it helps ...

would you be interested in making this refactor? I can tackle whenever I find some bandwidth though.

dfang commented 1 year ago

I think from the perspective of keeping it simple it's not necessary, with this PR, the most widely used tools should be covered, and the else could be installed by bin i <USER>/<REPO>. this could make config file simple.

marcosnils commented 1 year ago

:+1:. I'll refactor when I find the time. In the meantime I'll hold this PR since I don't want to hardcode custom shorthands in the code that will require a new release every time someone wants to add a new one.

dfang commented 1 year ago

Can you enable the discussions feature for this repo?

marcosnils commented 1 year ago

Sure, done

dfang commented 1 year ago

@marcosnils thanks, https://github.com/marcosnils/bin/discussions/172

marcosnils commented 3 months ago

closing since this didn't get too much traction and it has been stale for a while