marcosvidal / Sketch-Notebook

Sketch Plugin to make documenting design easier
http://marcosvid.al/sketch-notebook
1.29k stars 72 forks source link

Use different manifest identifiers for free, pro, lite, & premium to work with Sketch Plugin Manager #87

Closed mludowise closed 6 years ago

mludowise commented 7 years ago

I'm the owner of Sketch Plugin Manager and I've gotten feedback from a few users that my plugin is prompting Notebook Pro users to overwrite their Pro plugin with the free version from GitHub. The reason this is happening is because Plugin Manager checks the the currently installed plugin's manifest identifiers against those registered in the plugin-directory and prompts them to update to the latest version from GitHub.

The easiest fix for this is for the free version of Sketch Notebook to use a different identifier than Pro, Lite, or Premium. Perhaps something like "com.notebook.free".

To fix this issue for Plugin Manager, you'd only need to update the manifest for the Free version, but it's up to you if you also want to update them for Lite, Pro, and Premium.

mludowise commented 7 years ago

See https://github.com/marcosvidal/Sketch-Notebook/pull/88