Open ajwells128 opened 1 year ago
So is this resolved or not @ajwells128 ?
So is this resolved or not @ajwells128 ?
The PR is still open and has been unreviewed as far as I know. The code worked just fine last I checked it, not sure if any changes have been made since then. I don't have permission to merge the PR, though. If you are interested in benefitting from dark mode yourself before the PR merges, you can install the package in the usual way and then make these changes to the library files if you wish.
hello what's this about?
From: ajwells128 @.> Sent: 20 December 2023 14:40 To: marcotcr/lime @.> Cc: Subscribed @.***> Subject: Re: [marcotcr/lime] Implement Dark Mode for explanation.show_in_notebook method (PR #728)
So is this resolved or not @ajwells128https://github.com/ajwells128 ?
The PR is still open and has been unreviewed as far as I know. The code worked just fine last I checked it, not sure if any changes have been made since then. I don't have permission to merge the PR, though. If you are interested in benefitting from dark mode yourself before the PR merges, you can install the package in the usual way and then make these changes to the library files if you wish.
— Reply to this email directly, view it on GitHubhttps://github.com/marcotcr/lime/pull/728#issuecomment-1864588607, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APH5BTK54AUXITSPKYX2Y5TYKL2HLAVCNFSM6AAAAAA3AFGJMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUGU4DQNRQG4. You are receiving this because you are subscribed to this thread.Message ID: @.***>
Implement dark mode for explanation.show_in_notebook method by post-processing the formatted HTML.
Without this, in a notebook that is rendered in dark mode, the text is scarcely legible.
Example (from tutorial):