Does tests get in the production build?

marcoturi / ionic-boilerplate

✨ An Ionic Starter kit featuring Tests, E2E, Karma, Protractor, Jasmine, Istanbul, Gitlab CI, Automatic IPA and APK, TypeScript 2, TsLint, Codelyzer, Typedoc, Yarn, Rollup, and Webpack 2

MIT License

318 stars 107 forks source link

Does tests get in the production build? #27

Closed eidng8 closed 7 years ago

eidng8 commented 7 years ago

It seems that all tests will also be compiled during dev/prod build. Say, if I make a syntax error in the home.spec.ts, then run npm run dev or ionic build android, the error in the home.spec.ts will popup and breaks the build process.

marcoturi commented 7 years ago

The git flow suggested by this boilerplate is to push on production only after master's branch tests are passed. So the case you are suggesting is not possible and also the behaviour makes the build process safer to my point of view.