search

marcozaccari / markdown-diagrams-browser-extension

A browser extension for Chrome, Edge, Opera and Firefox that renders markdown diagrams and charts code blocks into preview images.
MIT License
60 stars 29 forks source link

Charts are duplicated in Mermaid website #1

Closed t1m0t closed 4 years ago

t1m0t commented 4 years ago

Hi, First, very good job for this excellent extension. Second, I've detected an issue: mermaid charts are duplicated in the mermaid website. Actually looks like the example snippets are directly interpreted. By double clicking on the interpreted examples, we can switch back to the code of the example. The html code generated looks like this:

<img src="https://kroki.io/mermaid/svg/eNpLL0osyFDwCeJSAILgksSiEgVdXTsgK78AAG50B-c=" title="Double click to switch code/render">

The mermaid website here

I'm not sure it is a normal behavior as we can't see the example snippets at first sight!

marcozaccari commented 4 years ago

Hi! The extension is doing its job, identifying renderable blocks of code in the Mermaid site too. I realize that allowing parsing in the example sites can confuse the user, so I have added all the official sites in the internal deny-list of the extension.

The issue will be automatically solved in the next version 1.1, actually in pending review in the various stores.

Hint: you can still toggle the extension activity in the whole page clicking directly to its icon in the extensions bar