search

marcpabst / ANOVA.jl

Provides a Simple Way to Calculate ANOVAs From Fitted Linear Models.
Other
21 stars 9 forks source link

A few fixes and design #10

Closed Nosferican closed 5 years ago

Nosferican commented 5 years ago
marcpabst commented 5 years ago

Looks good

marcpabst commented 5 years ago

Please let me know if you want me to push a new release...

Nosferican commented 5 years ago

Since that is a breaking change I might want to squeeze one or two other changes before the release. We are discussing https://github.com/JuliaStats/GLM.jl/pull/273 which could potentially make a breaking change. The idea is to always use CholeskyPivoted rather than depending on the allowrankdeficient option. That would simplify the code in this package and make it very similar to MixedModels which would help extending support to it. Feel welcome to comment your thoughts on the PR since it would affect this package.