Docs

[ghost]

Updated the Method docs strings.

[ghost]

I got it now I was not doing checks actually.

[marcpage]

It looks like you will need to merge the latest changes to your branch / fork (resolve conflict)

[marcpage]

I've done the merge.

[ghost]

I've done the merge.

To the main code base right?

[marcpage]

It looks like you are using a tool that reformats the source and your line length is less than 100. Please increase your maximum line length to 100. Much if the differences have nothing to do with your change but are your tool reformatting all the code to be less than (85?).

[ghost]

It looks like you are using a tool that reformats the source and your line length is less than 100. Please increase your maximum line length to 100. Much if the differences have nothing to do with your change but are your tool reformatting all the code to be less than (85?).

As I said before I am new to open source contribution. I need to learn more about it. I want your help in doing that so that I can keep on contributing to your Repo

[ghost]

Yes

On Sat, Jan 1, 2022, 12:43 AM Marc Page @.***> wrote:

It looks like you are using a tool that reformats the source and your line length is less than 100. Please increase your maximum line length to 100. Much if the differences have nothing to do with your change but are your tool reformatting all the code to be less than (85?).

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003438238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY2ZYUFVGF3SV62PPQTUTX6GXANCNFSM5LBNI3XQ . You are receiving this because you were assigned.Message ID: @.***>

[marcpage]

@avichal04, I would recommend resetting your fork back to the latest source from my main (or maybe just creating a new fork if that would be easier). Then do the following changes:

1. Increasing your tool (editor?) maximum python line length to 100 characters
2. Add .idea/ to the .gitignore file
3. Add in just your documentation updates

The run black on the source (if you are on macOS or Ubuntu, or maybe any Linux, you can just run ./pr_build.sh fix). That will format the source to pass the black test on the PR.

Your changes should be very minimal. If you go to the Files changed tab above, there should only be the changes you made (ie doc-strings and comments).

[ghost]

@marcpage I am using Vs code. I have not used it for contribution earlier. I am getting one that why I am still having the same code that do not have documentation in it. I am learning and applying it at the same time. so kindly help me out. Tell me how should I configure my VS Code for contributing to open source code projects. Thank you

On Sat, 1 Jan 2022 at 00:49, Marc Page @.***> wrote:

@avichal04 https://github.com/avichal04, I would recommend resetting your fork back to the latest source from my main (or maybe just creating a new fork if that would be easier). Then do the following changes:

1. Increasing your tool (editor?) maximum python line length to 100 characters
2. Add .idea/ to the .gitignore file
3. Add in just your documentation updates

The run black on the source (if you are on macOS or Ubuntu, or maybe any Linux, you can just run ./pr_build.sh fix). That will format the source to pass the black test on the PR.

Your changes should be very minimal. If you go to the Files changed tab above, there should only be the changes you made (ie doc-strings and comments).

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003439091, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY2BYC3K3JAG5VQJG5TUTX65TANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[marcpage]

No worries. I don't use VSCode, so I googled it and it looks like you can turn off the reformatter: https://stackoverflow.com/questions/737222/turn-off-auto-formatting-in-visual-studio#5493003

You'd want to turn it off for python

[ghost]

No worries. I don't use VSCode, so I googled it and it looks like you can turn off the reformatter: https://stackoverflow.com/questions/737222/turn-off-auto-formatting-in-visual-studio#5493003

You'd want to turn it off for python

I welcome your advice sir. I would like you suggest the same IDE as you are using so that I can also become good at that stuff.

[marcpage]

Depends on the platform you are on. I like to keep it simple. On macOS I use BBEdit. On Windows you could use NotePad+. On Linux there are so many options for simple editors, but I'm not familiar with them (I use the command-line vi tool)

[ghost]

Depends on the platform you are on. I like to keep it simple. On macOS I use BBEdit. On Windows you could use NotePad+. On Linux there are so many options for simple editors, but I'm not familiar with them (I use the command-line vi tool)

Sir I wanted to ask you that how should I approach contribution to open source because I think I made some error before from my side. And I am using Windows. I wanted to confirm whether my changes have been merged to the main code base or not. I don't why I am not able to see the changes in my forked repo. Also the changes I have made are still not visible in my editor. PLEASE GUIDE ME ON THAT SIR

[marcpage]

Absolutely. I would recommend creating a new fork and downloading Notepad++ and using it for all the source changes. That should make this process a lot simpler for you. At some point in the future you can go back to VSCode for editing, but let's keep it simple to get your changes in.

Another option, instead of forking, is to clone my repo, create a branch and do a pull request from that. Now that you are a contributor, you should be able to do that.

I have some pretty detailed instructions on using git from the command line in the README.md.

[ghost]

Absolutely. I would recommend creating a new fork and downloading Notepad++ and using it for all the source changes. That should make this process a lot simpler for you. At some point in the future you can go back to VSCode for editing, but let's keep it simple to get your changes in.

Another option, instead of forking, is to clone my repo, create a branch and do a pull request from that. Now that you are a contributor, you should be able to do that.

I have some pretty detailed instructions on using git from the command line in the README.md.

Thank you so much sir for clarifying it for me. Are my changes merged?

[marcpage]

Your changes are not merged. After you fix items from the review, you can mark each item as resolved. I'm looking now and resolving the ones that are resolved and seeing what is left

[marcpage]

Changes are now in main. Thank you

[ghost]

Your changes are not merged. After you fix items from the review, you can mark each item as resolved. I'm looking now and resolving the ones that are resolved and seeing what is left

Thank you so much sir.

[ghost]

Thank you so much sir. How can I further contribute to the project? I have deleted the docs branch now. So Please guide me how can I contribute to a open source in a good way. Thank you. Regards

On Sat, 1 Jan 2022 at 02:34, Marc Page @.***> wrote:

Changes are now in main. Thank you

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003450980, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY5NI4ARVDQQL3YEWRTUTYLGLANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[marcpage]

There are still a hand-full of good first issues. There are a couple of testing issues that would be great to have implemented. I'm not sure what your skillset is. There are some javascript, css, and image creation items that may be of interest to you.

Since you are on Windows, if you could implement #52 (Create a pr_build.bat) that would be really helpful, as I do not have access to a Windows machine. It is just creating a simple .bat file that will create a python virtual environment, setup that virtual environment, install the dependencies, run black, pylint, and flake8, and then run the test suite. The commands used for macOS and Linux are provided in the issue.

Feel free to assign yourself to whatever issue you are working on so we don't have duplicated work, that will be helpful.

Thanks again for your contributions.

[ghost]

Sir I know Python, HTML I don't know what should I learn because I don't have access to a mentor who will guide me.

I am just having Python as my skill set and I don't know what to learn next. That's why I took this much time to help you.

If would be great if you can help me with that. Please let me know that how many things do I have to learn more?

Please brief me on that sir. Your guidance will help me a lot. Thank you.

On Sat, Jan 1, 2022, 2:59 AM Marc Page @.***> wrote:

There are still a hand-full of good first issue https://github.com/marcpage/scheduling/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22s. There are a couple of testing issues that would be great to have implemented. I'm not sure what your skillset is. There are some javascript, css, and image creation items that may be of interest to you.

Since you are on Windows, if you could implement #52 https://github.com/marcpage/scheduling/issues/52 (Create a pr_build.bat) that would be really helpful, as I do not have access to a Windows machine. It is just creating a simple .bat file that will create a python virtual environment, setup that virtual environment, install the dependencies, run black, pylint, and flake8, and then run the test suite. The commands used for macOS and Linux are provided in the issue.

Feel free to assign yourself to whatever issue you are working on so we don't have duplicated work, that will be helpful.

Thanks again for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003453897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY5HXGRU6MMUANVXIATUTYOEPANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[marcpage]

This project is mainly html and python, so your skills will be perfect. If you'd like to be learning other skills, javascript will be used a lot as we got towards the end of the project and want to improve the interface.

As far as important work that needs to be done that requires just python skills, #36, #37, and #49 would be really valuable. We have some tests, but they need to be flushed out more. If you have any questions on any issues, feel free to start a discussion on the issue.

[ghost]

Sir how many languages should I have to learn? Your project is a golden opportunity for me. Sir as you I am completely new to this field (open source). So treat me as a beginner and sir guide me accordingly.

On Sat, Jan 1, 2022, 3:21 AM Marc Page @.***> wrote:

This project is mainly html and python, so your skills will be perfect. If you'd like to be learning other skills, javascript will be used a lot as we got towards the end of the project and want to improve the interface.

As far as important work that needs to be done that requires just python skills, #36 https://github.com/marcpage/scheduling/issues/36, #37 https://github.com/marcpage/scheduling/issues/37, and #49 https://github.com/marcpage/scheduling/issues/49 would be really valuable. We have some tests, but they need to be flushed out more. If you have any questions on any issues, feel free to start a discussion on the issue.

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003456103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY3D6ECNJOR27OC6JS3UTYQX7ANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[marcpage]

I would say learn one language very well, and then learn languages as you need them. Once you get the basics down, learning a new language is a matter of syntax and learning the libraries that are available. Many of the languages I have "learned" I can only really program in them with the help of Google/StackOverflow. Get comfortable searching google for questions you have about code. Often the top hits in Google will be StackOverflow results.

[marcpage]

For this project, python is the big one. html, css, and javascript would be helpful but you don't need a deep knowledge of any of those languages.

[ghost]

Thank you sir for your tips! I want to know how to start a project and manage it. I am confused about how different open source projects are released as different versions. Please let me know.

[marcpage]

As far as versioning on GitHub, I haven't done that yet, so I couldn't say. Once I figure it out, I'll let you know

[ghost]

As far as versioning on GitHub, I haven't done that yet, so I couldn't say. Once I figure it out, I'll let you know

Sir I want to ask, How you started to learn to code? What was your first language? How you started building projects in it? Like as a beginner we don't know what to learn next in programming. Please inform me about it..

[marcpage]

I started learning BASIC back in the 80's from a book I got from school. I would type in the simple programs and then modify them. Back then there was no internet. I subscribed to magazines that had code in them for games and I would type in the code and play the games.

I then took a Pascal class in college and got my first job coding in Pascal. I then took a C class and later an assembly, C++, and Java class. From there I just learned on my own, Ruby, Python, Perl, C#, Objective-C, Swift, Rust, Javascript,...

Since the advent of the internet, I still read and google about different aspects of languages I am coding in. Like "What is the best way to flatten a list of lists in python?" I've actually done that search several times. The homepage for the language and Stack Overflow have been a huge help. Sometimes I will purchases courses (like on Udemy) if the websites are not helping me fast enough (I've done this for Swift on iOS, actually I bought two courses).

The last 20 years I have been coding in C++ for a public company (with smatterings of other languages).

The language doesn't matter so much as the ability to learn a language. The language I am deepest on is C++, but I am quite proficient in Python, Swift, and Javascript (assuming I can google my questions). As I switch between languages I am constantly referring to the language reference materials online since there are subtle differences between all the languages.

I've found the best way to learn is to pick a language to go deep on, and then do a bunch of small personal projects in that language. Go deep in one language and learn it really well. Then start branching out to other languages.

For starting out, I've found some of the highly rated Udemy courses are pretty good. I'm not a fan of paying for things that are freely available online, but if you are struggling learning from the vast amount of information online, you may consider purchasing a course.

The other thing to consider is to immerse yourself in the language. Subscripe to YouTube videos about the language. Read the entire tutorial and go through the examples on the language's website. Create personal projects in the language to do simple things (I have over 400 python scripts I've written over the last decade in my quest to learn Python)

[ghost]

I started learning BASIC back in the 80's from a book I got from school. I would type in the simple programs and then modify them. Back then there was no internet. I subscribed to magazines that had code in them for games and I would type in the code and play the games.

I then took a Pascal class in college and got my first job coding in Pascal. I then took a C class and later an assembly, C++, and Java class. From there I just learned on my own, Ruby, Python, Perl, C#, Objective-C, Swift, Rust, Javascript,...

Since the advent of the internet, I still read and google about different aspects of languages I am coding in. Like "What is the best way to flatten a list of lists in python?" I've actually done that search several times. The homepage for the language and Stack Overflow have been a huge help. Sometimes I will purchases courses (like on Udemy) if the websites are not helping me fast enough (I've done this for Swift on iOS, actually I bought two courses).

The last 20 years I have been coding in C++ for a public company (with smatterings of other languages).

The language doesn't matter so much as the ability to learn a language. The language I am deepest on is C++, but I am quite proficient in Python, Swift, and Javascript (assuming I can google my questions). As I switch between languages I am constantly referring to the language reference materials online since there are subtle differences between all the languages.

I've found the best way to learn is to pick a language to go deep on, and then do a bunch of small personal projects in that language. Go deep in one language and learn it really well. Then start branching out to other languages.

For starting out, I've found some of the highly rated Udemy courses are pretty good. I'm not a fan of paying for things that are freely available online, but if you are struggling learning from the vast amount of information online, you may consider purchasing a course.

The other thing to consider is to immerse yourself in the language. Subscripe to YouTube videos about the language. Read the entire tutorial and go through the examples on the language's website. Create personal projects in the language to do simple things (I have over 400 python scripts I've written over the last decade in my quest to learn Python)

Sir can you please verify whether the link provided have legitimate content or not. I wanted to know that what kind of projects you've made. Can I have one of script for an abstract idea. Thank you for informing about your journey sir. https://www.engineeringwithutsav.com/coding-roadmap

[marcpage]

That coding roadmap looks decent from what I saw.

I have some old code here: https://github.com/marcpage/Python-Utilities

[ghost]

Thank you sir for your advice. While writing those scripts how you knew which module you need for it?

On Sun, Jan 2, 2022, 5:55 AM Marc Page @.***> wrote:

That coding roadmap looks decent from what I saw.

I have some old code here: https://github.com/marcpage/Python-Utilities

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003641401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY2DWZJAKYCZPQRA6MLUT6LOBANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[ghost]

I have seen the frontend of the "scheduling" repo. I think we should make it look attractive.

On Sun, 2 Jan 2022 at 09:50, Avichal Mishra @.***> wrote:

Thank you sir for your advice. While writing those scripts how you knew which module you need for it?

On Sun, Jan 2, 2022, 5:55 AM Marc Page @.***> wrote:

That coding roadmap looks decent from what I saw.

I have some old code here: https://github.com/marcpage/Python-Utilities

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003641401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY2DWZJAKYCZPQRA6MLUT6LOBANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[marcpage]

Agreed. There are several Issues related to visual aspects. If you have any ideas, feel free to create issues. Also feel free to work on any of them. I'm focused on getting the implementation completed. Then I'll go back and work on making it look better and more usable.

[marcpage]

On the modules, either they were modules I had used before, googled to find modules to do what I was wanting to do, or someone recommended them to me.

[ghost]

Ok, then I am going to add Visual looks too for better interface. How can I run your website on my machine because I don't the output of the code. Please let me know how can I run it.

On Mon, Jan 3, 2022, 1:04 AM Marc Page @.***> wrote:

Agreed. There are several Issues related to visual aspects. If you have any ideas, feel free to create issues. Also feel free to work on any of them. I'm focused on getting the implementation completed. Then I'll go back and work on making it look better and more usable.

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003764062, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY7HCXMOYT65SXMMHM3UUCSCRANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[ghost]

Yes I was asking for the same thing. I have lots of idea in my head but I don't what modules do I need to do that thing.

I have tried so much but failed as I lacked knowledge of Modules. If you can help me with that please let me know. Thank you.

On Mon, Jan 3, 2022, 1:05 AM Marc Page @.***> wrote:

On the modules, either they were modules I had used before, googled to find modules to do what I was wanting to do, or someone recommended them to me.

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003764207, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY7CVR2X5CUEVEHKMRDUUCSGNANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[ghost]

The User Interface will be my work, you work on the implementation part. Your project is so so interesting.. I can also help you in Implementation.

On Mon, Jan 3, 2022, 1:09 AM Avichal Mishra @.***> wrote:

Yes I was asking for the same thing. I have lots of idea in my head but I don't what modules do I need to do that thing.

I have tried so much but failed as I lacked knowledge of Modules. If you can help me with that please let me know. Thank you.

On Mon, Jan 3, 2022, 1:05 AM Marc Page @.***> wrote:

On the modules, either they were modules I had used before, googled to find modules to do what I was wanting to do, or someone recommended them to me.

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003764207, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY7CVR2X5CUEVEHKMRDUUCSGNANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[marcpage]

I don't have Windows, so I can't tell you for sure, but I can give you a general idea of how to run the web server. Issue #40 has some notes that might help.

You will need to create a python virtual environment, activate it, install the requirements, then run the script. So something like:

python3 -m venv C:\%TMP%\scheduling
C:\%TMP%\scheduling\Scripts\activate
pip3 install -qr Requirements.txt
python3 src\scheduling.py -s sqlite:///%APPDATA%/scheduling.sqlite3

The go http://localhost:8000/ in your web browser.

I'm not sure on the %TMP% directories above. They basically just need to be a place you can read/write on disk. the %APPDATA% is also a guess. It also needs to be a place to read/write on disk.

[ghost]

Ok I got your point. I am working on the UI. I Will send you the sample after completion.

On Mon, Jan 3, 2022, 1:32 AM Marc Page @.***> wrote:

I don't have Windows, so I can't tell you for sure, but I can give you a general idea of how to run the web server. Issue #40 https://github.com/marcpage/scheduling/issues/40 has some notes that might help.

You will need to create a python virtual environment https://medium.com/co-learning-lounge/create-virtual-environment-python-windows-2021-d947c3a3ca78, activate it https://docs.python.org/3/library/venv.html, install the requirements https://stackoverflow.com/questions/7225900/how-can-i-install-packages-using-pip-according-to-the-requirements-txt-file-from, then run the script. So something like:

python3 -m venv C:\%TMP%\scheduling C:\%TMP%\scheduling/Scripts/activate pip3 install -qr Requirements.txt python3 src\scheduling.py -s sqlite:///%APPDATA%/scheduling.sqlite3

The go http://localhost:8000/ in your web browser.

I'm not sure on the %TMP% directories above. They basically just need to be a place you can read/write on disk. the %APPDATA% is also a guess. It also needs to be a place to read/write on disk.

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003767481, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRYYKE4JL4LL7E4UXTITUUCVMLANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[marcpage]

I just put up pull request #62 that should fix it so you do not need to pass -s ... on Windows.

[ghost]

I just put up pull request #62 that should fix it so you do not need to pass -s ... on Windows.

So can you tell me how can I run it my Windows? Because I want to test it.

[marcpage]

If you don't have Python 3 installed, you would need to install that.

I think opening the command line (not sure how to do that or which command line to use on Windows).

If you cloned the source down on your machine in C:\scheduling then you would type:

C:
cd C:\scheduling
python3 -m venv C:\%TMP%\scheduling
C:\%TMP%\scheduling\Scripts\activate
pip3 install -qr Requirements.txt
python3 src\scheduling.py

Then type in your browser address bar http://localhost:8000

That should get you running. Then you can follow the instructions for boot-strapping in the README.md

[ghost]

Ok I was just asking you which do I need to run. I was confused actually. Thanks for clarification.

On Mon, Jan 3, 2022, 1:59 AM Marc Page @.***> wrote:

If you don't have Python 3 installed, you would need to install that.

I think opening the command line (not sure how to do that or which command line to use on Windows).

If you cloned the source down on your machine in C:\scheduling then you would type:

C: cd C:\scheduling python3 -m venv C:\%TMP%\scheduling C:\%TMP%\scheduling\Scripts\activate pip3 install -qr Requirements.txt python3 src\scheduling.py

Then type in your browser address bar http://localhost:8000

That should get you running. Then you can follow the instructions for boot-strapping in the README.md https://github.com/marcpage/scheduling/blob/main/README.md

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/pull/48#issuecomment-1003770682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY6UVPXZOANTF4UYTJLUUCYSVANCNFSM5LBNI3XQ . You are receiving this because you were mentioned.Message ID: @.***>

[ghost]

I have pulled request you can check the UI.

[marcpage]

I had the GitHub settings wrong. Apparently it completed the pull request without my review. I'm fixing up a few things now.

[ghost]

I had the GitHub settings wrong. Apparently it completed the pull request without my review. I'm fixing up a few things now.

Ok no problem I was waiting for review. Do you want a favicon in the Restaurant.html? Because I am working on it.

[marcpage]

That would be terrific.

[ghost]

That would be terrific.

Yes what I wanted to explain you is that your website should be good looking too. I know features are important but If a website is not good looking then user will not stay longer than 30 seconds. Another thing is that all the ".html" are so unclean. May be due to some problems but they are not looking good when opened.

I request you to see the 404.html and then inform me.

[marcpage]

I know the are not all that pretty. While at some point pretty will matter, it doesn't matter how pretty it is if it doesn't work. The polish can be added later and doesn't take deep knowledge of the model. While I have the model in my head I need to focus on coding up all the logic. I'll come back and clean up the ui (if no one else does, thank you for your efforts).

This is partially captured in Issue #51