search

marcpage / scheduling

Restaurant staff scheduling website
The Unlicense
3 stars 4 forks source link

[image] Create favicon for the website #52

Closed marcpage closed 2 years ago

marcpage commented 2 years ago

Having a favicon would make the site look more professional.

I was thinking a red, stylized R (for restaurant). Or maybe something like the cook emoji.

It can be stored in src/ui.

It can be .png or .ico.

marcpage commented 2 years ago

@avichal04 You had mentioned you have a favicon. Can you create a Pull Request with it?

ghost commented 2 years ago

I am actually checking whether it is looking nice or not. Sorry for late.

ghost commented 2 years ago

Why I am having problem in committing my code. It is showing conflicts .

On Mon, 3 Jan 2022 at 22:07, Marc Page @.***> wrote:

Assigned #52 https://github.com/marcpage/scheduling/issues/52 to @avichal04 https://github.com/avichal04.

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/issues/52#event-5836174527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY33N3D7ZC56NADDPCDUUHGD5ANCNFSM5LBV7ERQ . You are receiving this because you were assigned.Message ID: @.***>

marcpage commented 2 years ago

You'll need to merge the latest changes from my main branch, then resolve the conflicts, commit and push the fixes.

ghost commented 2 years ago

Got it.

On Tue, Jan 4, 2022, 1:29 AM Marc Page @.***> wrote:

You'll need to merge the latest changes from my main branch, then resolve the conflicts, commit and push the fixes.

— Reply to this email directly, view it on GitHub https://github.com/marcpage/scheduling/issues/52#issuecomment-1004322083, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7PRY5ICYFKQTLDK2WK5XLUUH5YTANCNFSM5LBV7ERQ . You are receiving this because you were mentioned.Message ID: @.***>

ghost commented 2 years ago

Where should I place the favicon files. The 404.css is not functioning. You have put the ".css" file outside template folder so may be that's the cause.

ghost commented 2 years ago

I am now moving all the favicon and css file in the template folder.

marcpage commented 2 years ago

The src/ui/template folder should only have text files that are generated dynamically (via a call to render_template, usually in src/schedule.py. All other files to be served up by the web server should be in src/ui.

ghost commented 2 years ago

Ok got it sir.