search

marcreichel / igdb-laravel

Simplify the integration of the IGDB API into your Laravel app. Including IGDB webhook support.
https://marcreichel.dev/docs/igdb-laravel
MIT License
104 stars 22 forks source link

Update composer.json for 5.8 release? #3

Closed lofonic closed 5 years ago

lofonic commented 5 years ago

Wondering if application compatibility includes 5.8 and if so can we get an update on the requirements to 5.7 and up?

marcreichel commented 5 years ago

Good Point. I Will definitely look into this!

lofonic commented 5 years ago

Cool, maybe as simple as making the composer requirement something like "laravel/framework": "5.*.*",

And just making sure it doesn't step on the toes of any 5.8 changes: https://laravel.com/docs/5.8/upgrade

lofonic commented 5 years ago

Ok I forked and tried removing the laravel requirement altogether it seems to work fine. Checking the 5.8 changes the only impact for this package appears to be with regards to caching which changes the amount to equal seconds instead of minutes however since you have a config folks can change the time in there easily enough.

marcreichel commented 5 years ago

Sounds great. Feel free to send me a PR. But make sure to add the Laravel dependency again as this package would not work without it 😄

lofonic commented 5 years ago

Will do, I'll pull a fresh fork since there's like 6 commits of me trying different composer file tests.

marcreichel commented 5 years ago

Leaving this issue open until you send me the PR