marcrobledo / RomPatcher.js

An IPS/UPS/APS/BPS/RUP/PPF/xdelta ROM patcher made in HTML5.
https://www.marcrobledo.com/RomPatcher.js/
Other
726 stars 141 forks source link

Check for headered ROM? #1

Closed gingerbeardman closed 6 years ago

gingerbeardman commented 6 years ago

Often a patch requires a specific ROM. Maybe headered, maybe unheadered.

Eg. Seiken Densetsu 3.

But your tool doesnt check for headers so it's possible to patch the wrong ROM?

frostitution commented 6 years ago

Adding on to this, maybe a way to just say "This patch requires a headered ROM" and during the patching process, add the header, apply the patch, then remove the header all in one swoop (similar to using TUSH)? Or modify the IPS file to strip the header out (similar to ipsbehead).

gingerbeardman commented 6 years ago

The IPS patch itself doesn't contain any information about whether the ROM it's meant to patch is headered, or indeed anything about the ROM.

So I think, similar to the other issue about checksums, the tool would need to use the metadata on the patch page to do these extra checks.

marcrobledo commented 6 years ago

I'll take a look at it. I can add a checkbox to add a temporary header before patching.

marcrobledo commented 6 years ago

Fixed in 5ea4024aaf6d32ff7958173e6fcab3e68a4d308b

What it does:

Changes are up, however I'm having problems with the old appcache file and it doesn't seem to show the latest files.

marcrobledo commented 6 years ago

Looks like it already loads the newest files. Can you confirm the new feature works as expected?

gingerbeardman commented 6 years ago

I'll try it tonight