search

marcrobledo / RomPatcher.js

An IPS/UPS/APS/BPS/RUP/PPF/xdelta ROM patcher made in HTML5.
https://www.marcrobledo.com/RomPatcher.js/
Other
653 stars 133 forks source link

feature request: name output file to patch name, not input name (patched) #31

Closed foxsouns closed 2 years ago

foxsouns commented 2 years ago

with most files, esp smw romhacks, it makes more sense to name it the name of the patch than to name it a generic smw patched thing. i might dive through the source code myself and find what makes the name, but i am garbage at js and would rather leave it to someone who knows what theyre doing.

marcrobledo commented 2 years ago

I've been going over adding a settings screen that would allow, among other things, choosing the output filename with both options. What do you think?

foxsouns commented 2 years ago

that sounds great!

laqieer commented 2 years ago

Temporary solution before @marcrobledo's official implementation: https://github.com/laqieer/RomPatcher.js/compare/84298e9cee234c7cf083e13c9a5dd8df3396f74f...f004662a9f68f9ad99a08ca62deeed4abaeb2a1d

marcrobledo commented 2 years ago

I managed to get some time to finish this at last! Hoping to release it soon :-)

marcrobledo commented 2 years ago

Any suggestion for a shorter setting label? imagen

laqieer commented 2 years ago

Any suggestion for a shorter setting label?

Output filename:

marcrobledo commented 2 years ago

Yeah, I already thought on those. But I'd rather prefer it to be a simple checkbox, not a dropdown (if possible).

foxsouns commented 2 years ago

Yeah, I already thought on those. But I'd rather prefer it to be a simple checkbox, not a dropdown (if possible).

Use patch name for output ?

marcrobledo commented 2 years ago

I've just deployed the new 2.6 version! Let me know what you think about it :-)

GB-CG commented 2 years ago

Your patcher over at RHDN is still using 2.5.1.

marcrobledo commented 2 years ago

Yes. I prefer to test it here before uploading it there.

foxsouns commented 2 years ago

@marcrobledo im not sure what is going on, but the site is not working on chromium.

Screenshot 1 Screenshot 2

marcrobledo commented 2 years ago

@marcrobledo im not sure what is going on, but the site is not working on chromium.

Looks like it hasn't loaded the CSS stylesheet for some reason. Can you try to force a cache refresh?

foxsouns commented 2 years ago

@marcrobledo im not sure what is going on, but the site is not working on chromium.

Looks like it hasn't loaded the CSS stylesheet for some reason. Can you try to force a cache refresh?

it is working now, after a refresh.