marcrobledo / RomPatcher.js

An IPS/UPS/APS/BPS/RUP/PPF/xdelta ROM patcher made in HTML5.
https://www.marcrobledo.com/RomPatcher.js/
Other
653 stars 133 forks source link

setMessage: Use l11n key and set data-localize attr #37

Closed flagrama closed 2 years ago

flagrama commented 2 years ago

Fixes #36

There are still some unlocalized strings out there, but since the localization string is set to a localized value, with a fallback to English if not found, with another fallback to "display the unknown key directly" if there isn't an English string either they display properly. Errors in particular would require a bit more work to make localized (additional param for appending another message? check if key is an array and append them in order? something like that) but beyond what I wanted to do here.

marcrobledo commented 2 years ago

Thank you! :-)