marcrobledo / RomPatcher.js

An IPS/UPS/APS/BPS/RUP/PPF/xdelta ROM patcher made in HTML5.
https://www.marcrobledo.com/RomPatcher.js/
Other
712 stars 141 forks source link

Deployment on https://www.romhacking.net/patch does not work on iOS #74

Open jacko-png opened 1 month ago

jacko-png commented 1 month ago

G'day,

I'm trying to patch this hack. I don't have my computer on me at the moment so I'm trying to use a website on my iPad.

I upload the ROM as a .gb, but I have to upload the patch renamed with an extension other than .ips due to iOS restrictions. My guess is that it failed because of this.

The JavaScript could also be unfriendly to iOS.

Fixes

My suggestion is to remove any checks of the extension. I don't know how you'd troubleshoot anything else.

Error response: Unknown.html.txt

(on iOS, I can't select html files. Excuse the extension.)

Software: iOS 16.5 Firefox

jacko-png commented 1 month ago

This is what the one at https://www.marcrobledo.com/RomPatcher.js/ spat out:

Unknown (4).html.txt

(I can't see the actual page until I upload it to GitHub)

Edit: I can't see what this one looks like in a web browser atm. I'll check when I'm at my computer next.

jacko-png commented 1 month ago

As it turns out, the uploading is unique to iPadOS. iPhones can upload .ips files, so that's a separate issue.

This issue still occurs with the correct .ips file.

Let's focus on the other symptoms:

Here is a video: https://github.com/user-attachments/assets/cdce62b9-2f2e-4c92-a51d-062f2c667e98

jacko-png commented 1 month ago

I just tried with Orion browser and it worked just fine. It would probably also work with Safari and Chrome.

This issue is specific to Firefox.

I'd be content if this issue was filed as wontfix given how not-worth-it troubleshooting browser incompatibility can be.