marcrobledo / savegame-editors

A compilation of console savegame editors made with HTML5 technologies.
https://www.marcrobledo.com/savegame-editors/
Other
1.11k stars 229 forks source link

TOTK Request Editable Weapon Modifiers #191

Closed Karlos007 closed 1 year ago

Karlos007 commented 1 year ago

B6EEDE09:No Bonus A9384C6C:Attack ↑ DAD10617:Attack ↑↑ D5CAD39B:Durability ↑ B2C943EE:Durability ↑↑ 7D505BC4:(Bow) Quick Shot 934069CD:(Bow) Arrow Shot x5 B3C94E5:(Shield) Block ↑↑ 9659C804:(Weapon) Throw ↑↑ D0EFAC53:(Weapon) Critical Hit +

image A +100 Attack ↑↑ looks like this

marcrobledo commented 1 year ago

This is a nice contribution, thank you! I've added the weapon modifier editor in 4e9828b.

Still, I'm not sure about power... Is it confirmed that power is now a fixed value independent of the modifier? BOTW was different if I recall correctly: you chose a modifier then a value for that modifier. Do we have any more information on that?

Karlos007 commented 1 year ago

In your editor the first box is durability the second is the mod value (on a legit weapon the max is 10 for yellow mods) so +10 attack or +10 durability the third the modifier type

The only changes from botw are that durability can't be 999999, unless you use the durability mod because the game resets higher values to the allowed maximum.

marcrobledo commented 1 year ago

Oh, that's interesting... so if you use the Durability ↑ or Durability ↑↑ mod, the durability value doesn't reset?

marcrobledo commented 1 year ago

BTW, I've added the missing modifiers. I haven't tested them, but they should work.

Karlos007 commented 1 year ago

Let's say you have a normal Hylian Shield but hacked with 9999 durability If you equip it it will reset to 800 If the modifier is durability +10 it it will reset to 810, the legit max And if the modifier value is durability +1000 it it will reset to 1800 And so on...

So you can either have a weapon with almost infinite durability or with almost infinite damage/guard In botw you could do both.

Karlos007 commented 1 year ago

BTW, I've added the missing modifiers. I haven't tested them, but they should work.

The finishing blow?? I tested and is D0EFAC53:(Weapon) Critical Hit + A white mod that can't be obtained once you are hight level and only get yellow mods

marcrobledo commented 1 year ago

Let's say you have a normal Hylian Shield but hacked with 9999 durability If you equip it it will reset to 800 If the modifier is durability +10 it it will reset to 810, the legit max And if the modifier value is durability +1000 it it will reset to 1800 And so on...

So you can either have a weapon with almost infinite durability or with almost infinite damage/guard In botw you could do both.

Do we know the maximum value the modifier value can be?

The finishing blow?? I tested and is D0EFAC53:(Weapon) Critical Hit + A white mod that can't be obtained once you are hight level and only get yellow mods

There is another one for bows: 0x54535b3c: Arrow Shot x3???

Karlos007 commented 1 year ago

the maximum value of the modifier is +10 legit for yellow and +5 for white with hacks it goes to 2147483647 and -2147483647 image image

For durability I wouldn't use more than 2147482847 since it may overflow to negative and literally break the shield on equip.

Arrow Shot x3 54535b3c doesn't seem to work only the x5 version 934069CD

also i found these offset for v1.0.0: 000A65D8:Weapon Attachment ID 1 000A6618:Weapon Attachment ID 2 000AA080:Shield Attach ID 1 000AA0C0:Shield Attach ID 2

and unrelated to this thread: 0003B8B4:Play Time (s) 0002A89C:Demon Statue - Containers

as always in 1.1 is a bit later in memory +38

CeruleanSky commented 1 year ago

Here is an unedited save with a great eagle bow with x3 shot so a proper value for x3 can be narrowed down, perhaps there is more than one type?

progress.zip

image

It loads different in the editor: image

marcrobledo commented 1 year ago

Added weapon value editor at last in ad209aa5f573b202379d253ee43f5938ec869912!

Also, added playtime and demon statue container (I don't even know what these are lol) editor (in Master Editor for now) in 1046993c8446f4f66e1d72a79bb713c4e43574d7. @Karlos007 if you are researching for other offsets, it would be great if you created a new issue and post them there.

Here is an unedited save with a great eagle bow with x3 shot so a proper value for x3 can be narrowed down, perhaps there is more than one type?

That's odd. It has No bonus with a value of 0xffffff. I'll leave the issue open for now, though it's not a priority at the moment.

asd123cqp commented 1 year ago

I guess now the max durability should also be updated to account for the modifier?

Invitation2Hades commented 1 year ago

I guess now the max durability should also be updated to account for the modifier?

Apparently that was already being discussed in this thread.

marcrobledo commented 1 year ago

I guess now the max durability should also be updated to account for the modifier?

If I understood @Karlos007 's explanation correctly, max durability always resets to its default value, no matter what its modifier is. The value you want to edit to make a weapon more durable is the modifier value.

Invitation2Hades commented 1 year ago

I guess now the max durability should also be updated to account for the modifier?

If I understood @Karlos007 's explanation correctly, max durability always resets to its default value, no matter what its modifier is. The value you want to edit to make a weapon more durable is the modifier value.

Durability does indeed reset to the max value of the item. However when a modifier is attached, its new higher value is the new max. So like for the example I used before you closed the issue, Hylian Shield max without modifiers is 800, however with a modifier like lets say durability up +10, the new max it should reset to is now 810.

Karlos007 commented 1 year ago

image basically both values should be high

Max durability is the base plus the modifier value

LittleFive55555 commented 1 year ago

Hi, bro. I wonder if fusing things may cause my durability hack not work. I hacked a magic wand to durability++2100000000. I fused that magic wand with a ruby to make a fire magic wand but after I used it for a few times, it was broken.

asd123cqp commented 1 year ago

Hi, bro. I wonder if fusing things may cause my durability hack not work. I hacked a magic wand to durability++2100000000. I fused that magic wand with a ruby to make a fire magic wand but after I used it for a few times, it was broken.

Per @Karlos007, this is because currently the max cap added 584cec1 does not account for the modifier value. You may remove the cap locally from zelda-totk.js for now and set the durability to the real max (refer to the comment above yours) until a proper fix is in place.

Karlos007 commented 1 year ago

editor seems to work fine with update v1.1.1

marcrobledo commented 1 year ago

Should be fixed now in c251d26!