marcrobledo / savegame-editors

A compilation of console savegame editors made with HTML5 technologies.
https://www.marcrobledo.com/savegame-editors/
Other
1.11k stars 229 forks source link

TOTK NEW Request: Can someone make it so you can remove some of the food items #227

Closed naijah closed 1 year ago

naijah commented 1 year ago

I can Only add items. I cant remove any Web capture_22-5-2023_11527_www marcrobledo com

beyondmeat commented 1 year ago

That makes sense but there should be a way to undo / remove it before you hit "save changes".

Lucifiish commented 1 year ago

An undo button would be a nice QoL feature, but I suspect that implementing it would have a plethora of issues - adding items to the inventory artificially is already somewhat risky; removing them would likely cause internal game issues. Setting the quantity to 1 and eating them in game is absolutely an efficient enough way to get that done.

Recommending closing this thread

marcrobledo commented 1 year ago

Added a button to remove items in 0885e4a, just hover the mouse over the desired item.

beyondmeat commented 1 year ago

An undo button would be a nice QoL feature, but I suspect that implementing it would have a plethora of issues - adding items to the inventory artificially is already somewhat risky; removing them would likely cause internal game issues. Setting the quantity to 1 and eating them in game is absolutely an efficient enough way to get that done.

Recommending closing this thread

The save only technically gets edited on "save changes" and that's a new file download technically. So the undo button would just pop that item from the queue of changes basically and the save wouldn't be affected. This can easily be done b/c the code can know what was added by the editor and not the save file and only display the delete button for changes 'not yet committed'. That would also prevent any unsafe operations happening on a file with those items already saved., bc the button wouldn't be there.

That said, depending on the code, it might require a few changes but nothing major.

Sure you could just reload the page and loadup the untouched file but you might then have to do a bunch re-edits and not very UX friendly.

marcrobledo commented 1 year ago

An undo button is definitively doable, but it is not as easy as it sounds and it's not in my priority list, sorry :-(

iMaxed0utHD commented 1 year ago

@marcrobledo Does this work for armor too or just materials? I accidentally clicked add armor when scrolling down to upgrade a piece and can't figure out to how delete the extra piece of armor.

beyondmeat commented 1 year ago

@iMaxed0utHD reload the unedited save and redo your changes. For the most part, unless it's zora armor, I don't think you will miss a cutscene or anything if you just sell the armor off in game.

marcrobledo commented 1 year ago

@marcrobledo Does this work for armor too or just materials? I accidentally clicked add armor when scrolling down to upgrade a piece and can't figure out to how delete the extra piece of armor.

It didn't, but now it does :-) I've just enabled the remove button for equipment added in the editor, sort of an undo button. @beyondmeat

iMaxed0utHD commented 1 year ago

@marcrobledo Does this work for armor too or just materials? I accidentally clicked add armor when scrolling down to upgrade a piece and can't figure out to how delete the extra piece of armor.

It didn't, but now it does :-)

I've just enabled the remove button for equipment added in the editor, sort of an undo button. @beyondmeat

Thank you! Super useful ^^

@beyondmeat I would have reloaded my save, but I didn't realize I did it until I had already edited tons of things then played for a few hours 😅

marcrobledo commented 1 year ago

@Sensei412 added a checkbox for this in the new setttings tab.

I figure there isn't much more that can be improved in item removal, so I'm closing the issue.