search

marcrobledo / savegame-editors

A compilation of console savegame editors made with HTML5 technologies.
https://www.marcrobledo.com/savegame-editors/
Other
1.11k stars 229 forks source link

(Bug) seems to corrupting autobuild log even without mess with it #301

Closed Shideravan closed 1 year ago

Shideravan commented 1 year ago

I haven't used the autobuild section yet (to say the truth, i didn't notice until that corrupts) but it probably corrupted the autobuild log and favorites in my save. Now press Y in favorites isn't removing it. I tried to import a old save to import at least some funcional autobuild, but it didn't fixed the problem. Can you have an "clear all log" option and a checkmark where the save editor doesn't change this part of code. I'm not sure it's your addition that did it, but since you just added it and I had the problem immediately after, I'm inferring it was the cause

Shideravan commented 1 year ago

I not sure if I can post the corrupted savegame directly here, but in case I can't then feel free to remove it. progress.zip

marcrobledo commented 1 year ago

I don't exactly understand what happened. What edits did you do? The autobuilder importer doesn't (or it shouldn't) write to the file unless you import a file. Can you post the original savegame so I can try to replicate the bug?

Shideravan commented 1 year ago

I don't exactly understand what happened. What edits did you do? The autobuilder importer doesn't (or it shouldn't) write to the file unless you import a file. Can you post the original savegame so I can try to replicate the bug?

I made edits mainly for pins. I also used some cheats too, that may be the other cause for the autobuild log corruption. I only realized until some time later playing that the autobuild history was corrupted. But I have a backup from some time way before. progress.zip

Shideravan commented 1 year ago

Probably this is related with this: https://github.com/marcrobledo/savegame-editors/issues/226

I think that just a feature to clear all the autobuild history will suffice and can be helpful for everyone that wants autobuild to return the same way it was when you first get from Master Kohga. The research can be done just comparing a save with full history with other save without any registers as like recently get from Master Kohga or even a clean new save that will probably have this part of autobuild clean. As autobuild history reflects in loadtime of the game, maybe this feature will be useful for even more users 😊

Shideravan commented 1 year ago

But as that is a very similar issue, I'll close this one