search

marcrobledo / savegame-editors

A compilation of console savegame editors made with HTML5 technologies.
https://www.marcrobledo.com/savegame-editors/
Other
1.09k stars 227 forks source link

TOTK: added armor upgrade modifier in the armor listing #360

Closed Syt-ha closed 1 year ago

Syt-ha commented 1 year ago

Hey, I made these changes for my own use, because upgrading every piece of armor was a bit tedious, I figured I might as well open a PR

I changed the way the Armor.AVAILABILITY is stored to put the "base armor" and its upgrades together in an object. I made the necessary changes everywhere it was needed to accomodate this new format.

I also added a "modifier" in the armors list to quickly change each armor piece upgrade level: Animation and a global modifier on the bottom of the listing to change every piece upgrade level at once Animation2

I hope this can be useful 👋

ApacheThunder commented 1 year ago

I vote in favor of this. On multiple occasions I accidentally set the wrong armor piece while "upgrading" them and ended up with 2 of the same thing when I went ingame to check. It's annoying and upgrade variants be separated into a separate UI element would help a lot with that issue. :P

marcrobledo commented 1 year ago

I'm so sorry for the late response :-(

I figure you saw the latest updates in the editor. I appreciate your contribution though.

Some weeks ago, I started a big update because this thing was getting too big and started to become hard to mantain. So it was screaming for a code clean up. I also added new planned features, which went into conflict with your PR.

I'm sorry you made something that was already in the works. But I had been swamped with work and life and decided not to visit GitHub for my own good.

Syt-ha commented 1 year ago

No worries at all!

I closed my merge request because I saw you already covered what I had added in your latest updates.

Private life comes first, and I totally get that, no need to apologize 🙌

This project is awesome (although I get why you needed to clean up the code 😄), I would have loved to contribute to it, maybe another time :)

Thanks for all the hard work you've put into it!