marcrobledo / savegame-editors

A compilation of console savegame editors made with HTML5 technologies.
https://www.marcrobledo.com/savegame-editors/
Other
1.09k stars 227 forks source link

TOTK: optimize item selection feature #394

Closed xiyuesaves closed 1 year ago

xiyuesaves commented 1 year ago

Hello, I tried to optimize the item selection function and added the ability to search for items, which will make it more convenient to use😀 file

marcrobledo commented 1 year ago

Haven't had a chance to try it but looks quite good!

Only downside I can see is that the ability to browse with up/down keyboard arrows is probably lost. Also, image lazy loading would be great (unless it's already implemented!).

xiyuesaves commented 1 year ago

Sorry, I have no way to solve the problem of not being able to use the up and down keys to switch between selections 😢, adding the 'lazy' attribute to the image element should be automatically handled by the browser

marcrobledo commented 1 year ago

I'll merge this one for sure, I promise. But give me some time please, got swamped with other things.

I'll also implement the keyboard selection.

xiyuesaves commented 1 year ago

I completely understand. Life always brings a lot of things to handle, and sometimes it can truly feel overwhelming. Please try to focus your attention on what you're currently dealing with. Also, I've done the keyboard selection function and it looks pretty good

video.webm

marcrobledo commented 1 year ago

Working on it!

I'm gonna add a few of little QoL changes if you don't mind.

marcrobledo commented 1 year ago

I finally managed to finish this!

Let me know if you have any questions on all changes I did, I'll be glad to answer.