marcrobledo / savegame-editors

A compilation of console savegame editors made with HTML5 technologies.
https://www.marcrobledo.com/savegame-editors/
Other
1.09k stars 227 forks source link

[TOTK] Armor dye dropdown appearing enabled when it shouldn't #421

Open phil-macrocheira opened 9 months ago

phil-macrocheira commented 9 months ago
marcrobledo commented 9 months ago

Indeed, those armors should appear as not dyeable: imagen

However, some months ago there was a little update (commit 6f4674d) that changed this. A mod creator reported that their mod allowed those armors to be dyed in-game. Since the editor is based in the original unmodded game, those armor dye dropdowns appeared as disabled. So when they opened the savegame in the editor and saved, it reseted their dye values. I did this small fix which only applies to mods: if you open a savegame that includes any of those armors with a dye, the dropdown does not appear disabled, so it keeps its value when saved. Probably, you are opening a modded savegame with that armor dyed. But if you set it to its default value, save and reopen it, the dropdown should appear again disabled. Let me know if it works.

As of Korok seeds, fixed! Thank you as always, Phil :-)

phil-macrocheira commented 9 months ago

Changing an armor in a slot (or even just clicking to change it and then clicking away) re-activates the dye dropdown. When an invalid color is selected, it re-disables the dye dropdown and displays an invalid icon for the armor. If saved, armor behaves normally but their icons do not render. Users must re-select the armor and change to 'Default color' before saving in the editor to fix it.