Server not communicating on control socket

marcsello / minecraftd

Minecraft server daemonizer for systemd compatiblity

MIT License

15 stars 5 forks source link

Server not communicating on control socket #2

Open marcsello opened 5 years ago

marcsello commented 5 years ago

After piping "say kaki" into minecraftd the daemon stopped sending out anyting (including history)

output:

marcsello@celestia:~$ echo "say kaki" | minecraftd
Session closed

After that, issuing 'minecraftd' does nothing.

even connecting to the pipe directly is not working:

marcsello@celestia:~$ nc -U /var/lib/minecraftd/control.sock

However it seems like the daemon is still running.

Sending SIGINT to the daemon causes it to stop properly (by shutting down the minecraft server). After restarting the service, the console is functioning again.

marcsello commented 5 years ago

It also seems like that it have something to do with the handling of special characters. After pressing Ctrl+F and then Ctrl+D the console session closes... but it does not work after that

marcsello commented 5 years ago

This issue is actually caused by two different bugs:

The client handler tried to decode to utf-8 everything the socket reader returned, but socket reader may return None if there is no new line.
When sending the history, a broken pipe error is not handled. piping anything inro minecraftd closes the socket just before history sending could be finished

Both are being worked on

marcsello commented 5 years ago

Crashing fixed in fddbe7cb7e6a649862b0ded468316aaf558c08eb and b7cfa0ef9a1bf95fcb7914cf423bf47ad8ff2a4d

But piping anything into the "minecraftd" command is not possible yet, because how it handles disconnecting. This issue is being worked on.