marcsowen / homebridge-homematicip

Homematic IP plugin for homebridge
Apache License 2.0
76 stars 18 forks source link

Error in HmIP-BSL Set Callback Handlers #557

Open smhex opened 1 month ago

smhex commented 1 month ago

I noticed that some of my HmIP-BSL scenes do not work anymore. I am not sure since when this has happened. Switching on the DEBUG mode I have seen the following error messages for all characteristics (On, Hue, Brightness, Saturation) which are modified in a specific scene:

[6/23/2024, 11:24:47 AM] [homebridge-homematicip] Characteristic 'On': SET handler returned write response value, though the characteristic doesn't support write response. See https://homebridge.io/w/JtMGR for more info.
[6/23/2024, 11:24:47 AM] [homebridge-homematicip] Error: 
    at On.Characteristic.characteristicWarning (/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:3016:105)
    at /homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2632:22
    at /homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/util/once.ts:15:18
    at HmIPSwitchNotificationLight.handleButton1LedBrightnessSet (file:///homebridge/node_modules/homebridge-homematicip/src/devices/HmIPSwitchNotificationLight.ts:218:5)
    at HmIPSwitchNotificationLight.handleButton1LedOnSet (file:///homebridge/node_modules/homebridge-homematicip/src/devices/HmIPSwitchNotificationLight.ts:196:7)

I will spent some more time to investigate here...

gkminix commented 1 day ago

No need to investigate. The BSL switches got a new firmware which requires a significant rewrite of the code. I have released a couple of patches to the code, which you can get the via github. Marc was so kind to include them into his source code . If possible, do also merge my latest commits which fix a couple of bugs.

smhex commented 1 day ago

Thanks, I will update my installation as soon as Marc has merged your PR's.