CSS Fix and File Format Change

marcus-j-davies / nvr-js

A simple, lightweight, but very functional NVR aimed at 24/7 recording using nodejs.

MIT License

25 stars 13 forks source link

CSS Fix and File Format Change #8

Closed codewizard1975 closed 2 years ago

codewizard1975 commented 2 years ago

The following changes are being submitted:

Removed fixed height from left sidebar camera cell
- Original was set for 16:9 based camera image as was discovered from fixed height in CSS
- Most IP cameras support 16:9 and 4:3 resolutions
Changed recorded file format to MKV from MP4
- This allows for better error handling in case of video interruption during writing
- Also allows for real-time playback of current recording instead of waiting for file write completion

marcus-j-davies commented 2 years ago

HI @codewizard1975

Thanks for your contribution, I will check this out soon.

marcus-j-davies commented 2 years ago

Hi @codewizard1975 Can the MKV files still be viewed from a web browser using the standard video tag?

codewizard1975 commented 2 years ago

My testing showed it played back in the browser just fine, tested on Firefox and Brave (Chrome) with no issues experienced.

marcus-j-davies commented 2 years ago

Cool!

Will aim to have a maintenance run with this module in the next week or so, so will look to merge these changes.

KeithHanson commented 2 years ago

+1 for MKV :) Very useful for security footage in general. Great to hear it played back via video tag so easily!

marcus-j-davies commented 2 years ago

@codewizard1975

The project is undergoing some review - the aim is to make it more robust one of which involves moving to MKV (pending test results).

This leaves just the UI edits you provided (Thank you). - However, I will at this point terminate the PR, but I will be looking at the edits again, at the end of my review exercise.

At this stage - I thank you