search

marcus-ny / pe

0 stars 0 forks source link

On adding clients, email should enforce the domain name to be non empty #4

Open marcus-ny opened 6 months ago

marcus-ny commented 6 months ago

Description: In add command, email should enforce the domain name to be non empty (emails such as a@com should not be accepted)

Steps to reproduce:

  1. add n/Adam p/00009999 e/a@com

Screenshots: Screenshot 2024-04-19 at 4.25.27 PM.png

Expected behaviour: Email is not valid so the add command should not be executed. Instead an error message should be displayed prompting the user to correct their email input.

Actual behaviour: The add command executes successfully and the contact is added to the list of clients.

soc-se-bot commented 6 months ago

Team's Response

2. This is followed by a '@' and then a domain name. The domain name is made up of one or more domain labels separated by periods. Quoting the UG, the domain name is present in the example given as it is made up of 1 or more domain labels after @

image.png

Also, as mentioned above felix@asd is a valid email (available in the UG).

Tag is changed from a functionality bug to a feature flaw as this is a missing functionality of an existing feature.

Our email validator follows the HTML5 standard see stackoverflow and wikipedia

Thus, we would like to suggest that this issue be rejected, as this is not a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]