nus-se-bot
commented
6 months ago Team's Response
It is unlikely that a user would be updating the email to an email of a person that is already in the list. Therefore, we suggest reducing the severity of this bug to Low. Also, the reason that this is implemented like this because there might be certain scenarios that they might have clients that are parents of a another client. The child may not have an email id and is thus using the same email as the parent. Furthermore, elderly clients might not have an email id, and share their email id with another client (that happens to be their child/relative). Therefore, we suggest this bug be marked as NotINScope
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Multiple person can have the same email address
[original: nus-cs2103-AY2324S2/pe-interim#859] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Good catch! However, the reason that this is implemented like this because there might be certain scenarios that they might have clients that are parents of a another client. The child may not have an email id and is thus using the same email as the parent. Furthermore, elderly clients might not have an email id, and share their email id with another client (that happens to be their child/relative).
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
Description: Updating the user's email to another existing user's email is allowed
Precondition: 2 contacts exist as shown in the screenshot below
Steps to reproduce:
Expected behaviour: This should not be allowed and should result in an error message since the person Adam already has the email a@com, and emails are unique
Actual behaviour: The update command executes successfully, resulting in both Adam and Blake having the same email.
Notes: Since emails are unique, unless two people are sharing an email (unlikely), this should not be accepted. In the case of typos, (if someone enters an existing contact's email by accident) this could lead to unnoticed mistakes that can hinder the user in the future (for example, not knowing who the actual owner of the duplicated email is)