marcus-ny / pe

0 stars 0 forks source link

Display command does not accept partial name prompts but executes anyway and displays the result of find command #9

Open marcus-ny opened 6 months ago

marcus-ny commented 6 months ago

Description: Display command does not accept partial name prompts as stated in the UG. However, the command seems to execute partially and displays the result of finding users with that partial name.

Preconditions: Have these 2 contacts in the list as shown below.

Screenshot 2024-04-19 at 4.54.24 PM.png

Steps to reproduce:

  1. run display adam

Expected behaviour: According to the UG, command should not execute since the name does not exactly match anyone in the database. Therefore, the UI should not change as well.

Actual behaviour: The app seems to filter the contact list to show only the people with the name Adam inside. (perhaps the find command has been executed partially)

An error message is also displayed stating as shown in the screenshot.

Screenshot 2024-04-19 at 4.54.41 PM.png

Notes: Since the UG states that we need the full name as parameter, the command should not execute at all.

nus-pe-bot commented 6 months ago

Team's Response

The UG states that to display a client's name, the full name must be entered. If partial names are entered, the application makes it easier for the user by filtering the list to show names that contain the inputted keywords. By throwing an error on partial names, it could indicate to the user that the client does not exist.

Since this behaviour is intended, we decide to reject this bug. Moreover, we change the severity from medium to low as this does not cause inconvenience to the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]